Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758098AbaGWQLq (ORCPT ); Wed, 23 Jul 2014 12:11:46 -0400 Received: from ns.mm-sol.com ([37.157.136.199]:52226 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757744AbaGWQLo (ORCPT ); Wed, 23 Jul 2014 12:11:44 -0400 Message-ID: <1406131883.2585.45.camel@iivanov-dev> Subject: Re: [PATCH v2 2/4] pinctrl: qpnp: Qualcomm PMIC pin controller driver From: "Ivan T. Ivanov" To: Linus Walleij Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Bjorn Andersson , Mark Brown , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Date: Wed, 23 Jul 2014 19:11:23 +0300 In-Reply-To: References: <1405610748-7583-1-git-send-email-iivanov@mm-sol.com> <1405610748-7583-3-git-send-email-iivanov@mm-sol.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.1-2ubuntu2~saucy1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-07-23 at 17:27 +0200, Linus Walleij wrote: > On Thu, Jul 17, 2014 at 5:25 PM, Ivan T. Ivanov wrote: > > > From: "Ivan T. Ivanov" > > > > This is the pinctrl, pinmux, pinconf and gpiolib driver for the > > Qualcomm GPIO and MPP sub-function blocks found in the PMIC chips. > > > > Signed-off-by: Ivan T. Ivanov > (...) > > +static int qpnp_pinctrl_remove(struct platform_device *pdev) > > +{ > > + struct qpnp_pinctrl *qctrl = platform_get_drvdata(pdev); > > + > > + pinctrl_unregister(qctrl->ctrl); > > + > > + return gpiochip_remove(&qctrl->chip); > > We're removing the return value from gpiochip_remove() and I > have dropped the __must_check attribute today, so just remove > it unconditionally and return 0; Yes, I know. Patches are based on v3.16-rc6 tag. > > Sorry for short and lame comment on a large patch I should look > closer at, but atleast it's something. Thanks, Ivan > > Yours, > Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/