Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758490AbaGWX1d (ORCPT ); Wed, 23 Jul 2014 19:27:33 -0400 Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:18109 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758444AbaGWX1b (ORCPT ); Wed, 23 Jul 2014 19:27:31 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 96.249.243.124 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+bzcR6Fc+ax89hiy+QKovtZZ/38dZQokY= X-DKIM: OpenDKIM Filter v2.0.1 titan 064545B452E Date: Wed, 23 Jul 2014 19:27:15 -0400 From: Jason Cooper To: Benoit Masson Cc: benoitm@perenite.com, Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, gregory.clement@free-electrons.com, sebastian.hesselbarth@googlemail.com Subject: Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Message-ID: <20140723232715.GL23220@titan.lakedaemon.net> References: <1406155973-13657-1-git-send-email-yahoo@perenite.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406155973-13657-1-git-send-email-yahoo@perenite.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Benoit, This looks a lot better, thanks for turning it around so quickly! My only general comment is just for the future. When submitting new versions of patches, please add a 'V2' inside the brackets on the Subject line. Or v3, or v4, or v14 in rare cases ;-) It really helps us patch wranglers keep track of which version to apply. One small comment below. On Wed, Jul 23, 2014 at 03:52:53PM -0700, Benoit Masson wrote: > The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb, > USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU. > > http://shop.lenovo.com/fr/fr/servers/network-storage/lenovoemc/ix4-300d/ > Signed-off-by: Benoit Masson > --- > arch/arm/boot/dts/Makefile | 3 +- > arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 284 ++++++++++++++++++++++++ > 2 files changed, 286 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts ... > diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts > new file mode 100644 > index 0000000..1f33cbc > --- /dev/null > +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts ... > + /* Warning: you need both eth1 & 0 PHY initialized > + (i.e having them up does the tweak) > + for poweroff to shutdown otherwise it reboots */ nit: multi-line comments are like this: /* * Warning: you need both eth1 & 0 PHY initialized (i.e having * them up does the tweak) for poweroff to shutdown otherwise it * reboots */ If that's the only thing left, I'll fix it up when I pull it in. No need to respin just for this. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/