Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758566AbaGWXeY (ORCPT ); Wed, 23 Jul 2014 19:34:24 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:52137 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758143AbaGWXeW (ORCPT ); Wed, 23 Jul 2014 19:34:22 -0400 Date: Thu, 24 Jul 2014 01:29:09 +0200 From: Andrew Lunn To: Jason Cooper Cc: Benoit Masson , benoitm@perenite.com, Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, gregory.clement@free-electrons.com, sebastian.hesselbarth@googlemail.com Subject: Re: [PATCH 2/2] ARM: mvebu: Added dts defintion for Lenovo Iomega ix4-300d NAS Message-ID: <20140723232909.GE28485@lunn.ch> References: <1406155973-13657-1-git-send-email-yahoo@perenite.com> <20140723232715.GL23220@titan.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140723232715.GL23220@titan.lakedaemon.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Wed, Jul 23, 2014 at 03:52:53PM -0700, Benoit Masson wrote: > > The Lenovo Iomega ix4-300d is a 4-Bay sata NAS with dual Gb, > > USB2.0 & 3.0, powered by a Marvell Armada XP MV78230 dual core CPU. > > > > http://shop.lenovo.com/fr/fr/servers/network-storage/lenovoemc/ix4-300d/ > > Signed-off-by: Benoit Masson > > --- > > arch/arm/boot/dts/Makefile | 3 +- > > arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts | 284 ++++++++++++++++++++++++ > > 2 files changed, 286 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts > ... > > diff --git a/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts > > new file mode 100644 > > index 0000000..1f33cbc > > --- /dev/null > > +++ b/arch/arm/boot/dts/armada-xp-lenovo-ix4-300d.dts > ... > > + /* Warning: you need both eth1 & 0 PHY initialized > > + (i.e having them up does the tweak) > > + for poweroff to shutdown otherwise it reboots */ > > nit: multi-line comments are like this: > > /* > * Warning: you need both eth1 & 0 PHY initialized (i.e having > * them up does the tweak) for poweroff to shutdown otherwise it > * reboots > */ > > If that's the only thing left, I'll fix it up when I pull it in. No > need to respin just for this. Hi Jason We should not really leave the i2c compatibility string as it is. Hopefully the OEM moved onto B1 stepping at some point. Although B1 devices will work with the workaround, you get better performance without it. We should wait for Gregory to look at the quirk and soc-id code. Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/