Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757370AbaGXB1k (ORCPT ); Wed, 23 Jul 2014 21:27:40 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:40383 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752788AbaGXB1j (ORCPT ); Wed, 23 Jul 2014 21:27:39 -0400 Date: Wed, 23 Jul 2014 18:27:30 -0700 From: Brian Norris To: bpqw Cc: "dwmw2@infradead.org" , "b32955@freescale.com" , "artem.bityutskiy@linux.intel.com" , "ron@debian.org" , "u.kleine-koenig@pengutronix.de" , "ezequiel.garcia@free-electrons.com" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: Subject: [PATCH 1/1] mtd:nand:fix nand_lock/unlock() function Message-ID: <20140724012730.GA3711@ld-irv-0074> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi White, On Thu, Jul 24, 2014 at 01:00:01AM +0000, bpqw wrote: > Do nand reset before write protect check > If we want to check the WP# low or high through STATUS READ and check bit 7, > we must reset the device, other operation (eg.erase/program a locked block) can > also clear the bit 7 of status register. > > Signed-off-by: White Ding > --- > drivers/mtd/nand/nand_base.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c > index 41167e9..22dd3aa 100644 > --- a/drivers/mtd/nand/nand_base.c > +++ b/drivers/mtd/nand/nand_base.c > @@ -965,6 +965,15 @@ int nand_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) [...] > @@ -1015,6 +1024,15 @@ int nand_lock(struct mtd_info *mtd, loff_t ofs, uint64_t len) [...] I don't see any in-tree users of nand_{un,}lock(). I recently caught a bug in nand_lock() via inspection (still need to send a fix), but I was considering dropping the functions entirely. I presume you have some out-of-tree driver that uses these functions, then? Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/