Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759017AbaGXNHr (ORCPT ); Thu, 24 Jul 2014 09:07:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49087 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758827AbaGXNHp (ORCPT ); Thu, 24 Jul 2014 09:07:45 -0400 Message-ID: <53D1051D.4060204@suse.cz> Date: Thu, 24 Jul 2014 15:07:41 +0200 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Nick Krause , Sasha Levin CC: Greg KH , Alan Stern , mail@beyermatthias.de, hdegoede@redhat.com, dan.j.williams@intel.com, valentine.barshak@cogentembedded.com, Ming Lei , Michael Opdenacker , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb-core: Remove Fix mes in file hcd.c References: <1405704880-10036-1-git-send-email-xerofoify@gmail.com> <53C9D997.7000409@kernel.org> <53CF0550.2040309@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/23/2014 05:24 AM, Nick Krause wrote: > On Tue, Jul 22, 2014 at 8:44 PM, Sasha Levin wrote: >> On 07/18/2014 10:52 PM, Nick Krause wrote: >>>>> Please explain exactly why it's not needed, why it can never be NULL, and >>>>> what prevents it from being NULL. >>>>> >>>>> "after dicussing" (do you run spellcheck on your mails?) won't mean anything >>>>> to someone looking at this commit in a year. >>>>> >>>>> Your commit message also mentions usb_device which has nothing to do with >>>>> your patch. >>>>> >>>>> >>>>> Thanks, >>>>> Sasha >>> >>> Sasha , >>> Greg seems to have signed it off. >>> Cheers Nick >> >> Greg? >> >> Even if the patch is correct (and I'm not saying it is) the commit message is way off. >> >> >> Thanks, >> Sasha > > > Sasha, > The patch is in the kernel now. Greg's tree is not Linus' tree, so it's not set to stone in git commit history yet. > I am not going through the trouble of removing > it, if you want to fix the commit message go on ahead. > Nick This kind of attitude might significantly lower your chances of future patches being accepted. Vlastimil > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/