Date: Thu, 24 Jul 2014 08:55:21 -0700
From: =?utf-8?B?U8O2cmVu?= Brinkmann <soren.brinkmann@xilinx.com>
To: Michal Simek <michal.simek@xilinx.com>
CC: <linux-arm-kernel@lists.infradead.org>, <monstr@monstr.eu>,
        Josh Cartwright <josh.cartwright@ni.com>,
        Steffen Trumtrar <s.trumtrar@pengutronix.de>,
        Rob Herring <robherring2@gmail.com>,
        Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: zynq: DT: Add CAN node
References: <52d799e17cd3539713625c6f6a6666620f52d692.1406120732.git.michal.simek@xilinx.com>
 <20140723160702.GA14564@xsjandreislx>
 <2fe3a869-d17c-4521-a5c1-7c347ae34726@BN1BFFO11FD060.protection.gbl>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2fe3a869-d17c-4521-a5c1-7c347ae34726@BN1BFFO11FD060.protection.gbl>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-ID: <d973d7c8-30e7-458e-9d57-15da917cde04@BL2FFO11FD030.protection.gbl>
Sender: linux-kernel-owner@vger.kernel.org

On Thu, 2014-07-24 at 08:44AM +0200, Michal Simek wrote:
> On 07/23/2014 06:07 PM, Sören Brinkmann wrote:
> > On Wed, 2014-07-23 at 03:05PM +0200, Michal Simek wrote:
> >> Add node describing Zynq's CAN controller.
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >>  arch/arm/boot/dts/zynq-7000.dtsi | 13 ++++++++++++-
> >>  1 file changed, 12 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> >> index 366ca6434f54..2287d9b4ed1a 100644
> >> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> >> @@ -71,7 +71,18 @@
> >>  			interrupts = <0 7 4>;
> >>  			interrupt-parent = <&intc>;
> >>  			clocks = <&clkc 12>;
> >> -		};
> >> +		};
> >> +
> >> +		can0: can@e0008000 {
> >> +			compatible = "xlnx,zynq-can-1.0";
> >> +			clocks = <&clkc 19>, <&clkc 36>;
> >> +			clock-names = "can_clk", "pclk";
> >> +			reg = <0xe0008000 0x1000>;
> >> +			interrupts = <0 28 4>;
> >> +			interrupt-parent = <&intc>;
> >> +			tx-fifo-depth = <0x40>;
> >> +			rx-fifo-depth = <0x40>;
> >> +		};
> > 
> > What about the second CAN core? You also probably want to add
> > 'status = "disabled"' in the dtsi.
> 
> Second can core - yes.
> 
> I can add status = "disabled" but then question is if make
> sense to change status for any zynq dts file. Or just
> keep enable both.
> 
> In our repo is enabled can0 on zc702.
> 
> What do you think?

Well, it should be enabled on boards that have CAN pinned out. Does any
of our boards have that?

	Sören

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/