Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759518AbaGXQMd (ORCPT ); Thu, 24 Jul 2014 12:12:33 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:51038 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759323AbaGXQMc (ORCPT ); Thu, 24 Jul 2014 12:12:32 -0400 Date: Thu, 24 Jul 2014 18:12:25 +0200 From: Sam Ravnborg To: Ard Biesheuvel Cc: Andreas Schwab , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arm64/crypto: fix makefile rule for aes-glue-%.o Message-ID: <20140724161225.GA11204@ravnborg.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 24, 2014 at 04:24:48PM +0200, Ard Biesheuvel wrote: > On 24 July 2014 16:18, Ard Biesheuvel wrote: > > On 24 July 2014 15:40, Andreas Schwab wrote: > >> Ard Biesheuvel writes: > >> > >>> On 24 July 2014 15:26, Andreas Schwab wrote: > >>>> You are not using CONFIG_MODVERSIONS. > >>>> > >>> > >>> I am > >> > >> No, you aren't, since you say that your .cmd contains a command to > >> create aes-glue-ce.o, which with CONFIG_MODVERSIONS it doesn't. > >> > > > > OK, you're right, it contains a command to create .tmp_aes-glue-ce.o. > > But I am still not seeing the error you are seeing, strangely enough. > > OK, now I am seeing it. > > Acked-by: Ard Biesheuvel Jumping in the end of the thread here - sorry for that. Another way to solve this would be to create two small wrapper files: aes-glue-neon.c - which include aes-glue.c aes-glue-ce.c that include aes-glue.c Then you could use standard kbuild support for building your module. And we will not potentially break it when we change cc_o_c in the near future. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/