Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759633AbaGXQf4 (ORCPT ); Thu, 24 Jul 2014 12:35:56 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:39836 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758548AbaGXQfz convert rfc822-to-8bit (ORCPT ); Thu, 24 Jul 2014 12:35:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <1406156581-6052-1-git-send-email-xerofoify@gmail.com> <20140724144725.GA32669@home.goodmis.org> <20140724105132.3cf221c2@gandalf.local.home> Date: Thu, 24 Jul 2014 12:35:54 -0400 Message-ID: Subject: Re: [PATCH] staging: Change kzalloc to kcalloc From: Nick Krause To: =?UTF-8?B?TcOlbnMgUnVsbGfDpXJk?= Cc: Steven Rostedt , Greg KH , John Stultz , paul.gortmaker@windriver.com, gang.chen.5i5j@gmail.com, yongjun_wei@trendmicro.com.cn, Dan Carpenter , tomas.winkler@intel.com, "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård wrote: > Nick Krause writes: > >> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård wrote: >>> Steven Rostedt writes: >>> >>>> On Thu, 24 Jul 2014 10:47:25 -0400 >>>> Steven Rostedt wrote: >>>> >>>>> The three parameters are the number of elements, the size of each individual >>>>> element, and then finally the flags used on how to allocate that memory. >>>>> I have to say, you did get the flags part correct. >>>>> >>>>> Now lets look at what you did. For the size you had: >>>> >>>> That should have read "For the count you had:" >>>> >>>> Oh well, you get my point anyway. >>> >>> I have some doubts about the last bit. >> >> I am have this discussion with other kernel developers and just >> because I send out one patch as a newbie like this doesn't mean I >> don't known C. > > Now I no longer have doubts; I know for certain that the point didn't > get across. > > -- > Måns Rullgård > mans@mansr.com I get your point try other things but I talked to other kernel developers and most of them seemed to get this feedback to when they started. Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/