Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759600AbaGXRcs (ORCPT ); Thu, 24 Jul 2014 13:32:48 -0400 Received: from mail-pd0-f181.google.com ([209.85.192.181]:57002 "EHLO mail-pd0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758866AbaGXRcq (ORCPT ); Thu, 24 Jul 2014 13:32:46 -0400 Date: Fri, 25 Jul 2014 01:31:12 +0800 From: Wang YanQing To: Rickard Strandqvist Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Jingoo Han , David Fries , Greg Kroah-Hartman , Joe Perches , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] video: fbdev: uvesafb.c: Added additional error checking Message-ID: <20140724173112.GA2015@udknight> Mail-Followup-To: Wang YanQing , Rickard Strandqvist , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Jingoo Han , David Fries , Greg Kroah-Hartman , Joe Perches , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1406150427-26077-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406150427-26077-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 23, 2014 at 11:20:27PM +0200, Rickard Strandqvist wrote: > Variable was assigned a value that is never used. > Now the variable is used, and the function returns if a call to > uvesafb_exec() returns a error. Because the only user of uvesafb_vbe_getpmi in uvesafb.c don't check its return value, it should do the check indeed, so maybe below change is better: - if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) { + if (err || (task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) { par->pmi_setpal = par->ypan = 0; } Or we check uvesafb_vbe_getpmi's return value, then the code will looks like below: if (uvesafb_vbe_getpmi(task, par)) par->pmi_setpal = par->ypan = 0; Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/