Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758857AbaGYDNU (ORCPT ); Thu, 24 Jul 2014 23:13:20 -0400 Received: from mail-vc0-f172.google.com ([209.85.220.172]:52402 "EHLO mail-vc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758698AbaGYDNR (ORCPT ); Thu, 24 Jul 2014 23:13:17 -0400 MIME-Version: 1.0 In-Reply-To: References: <1405996804-8262-1-git-send-email-guz.fnst@cn.fujitsu.com> <1405996804-8262-2-git-send-email-guz.fnst@cn.fujitsu.com> Date: Fri, 25 Jul 2014 11:13:16 +0800 Message-ID: Subject: Re: [PATCH 2/4] aio: use the macro rather than the inline magic number From: Ming Lei To: Jeff Moyer Cc: Gu Zheng , Benjamin LaHaise , Jens Axboe , Andrew Morton , "open list:AIO" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 22, 2014 at 9:54 PM, Jeff Moyer wrote: > Gu Zheng writes: > >> Signed-off-by: Gu Zheng > > Reviewed-by: Jeff Moyer > >> --- >> fs/aio.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/aio.c b/fs/aio.c >> index ad35876..1dc6158 100644 >> --- a/fs/aio.c >> +++ b/fs/aio.c >> @@ -201,7 +201,7 @@ static struct dentry *aio_mount(struct file_system_type *fs_type, >> static const struct dentry_operations ops = { >> .d_dname = simple_dname, >> }; >> - return mount_pseudo(fs_type, "aio:", NULL, &ops, 0xa10a10a1); >> + return mount_pseudo(fs_type, "aio:", NULL, &ops, AIO_RING_MAGIC); IMO, it might be better to use a new macro like AIO_FS_MAGIC with same number here because the same magic number 0xa10a10a1 serves for two purposes. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/