Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760003AbaGYIm6 (ORCPT ); Fri, 25 Jul 2014 04:42:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35092 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759603AbaGYIm4 (ORCPT ); Fri, 25 Jul 2014 04:42:56 -0400 Message-ID: <53D21887.2020305@suse.de> Date: Fri, 25 Jul 2014 10:42:47 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: monstr@monstr.eu, =?UTF-8?B?U8O2cmVuIEJyaW5rbWFubg==?= CC: Harini Katakam , Michal Simek , Andreas Olofsson , Matteo Vit , Sean Rickerd , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King Subject: Re: [PATCH v2 05/11] ARM: dts: zynq: Add QSPI for Parallella References: <1406242820-20140-1-git-send-email-afaerber@suse.de> <1406242820-20140-6-git-send-email-afaerber@suse.de> <53D20E5B.9070501@monstr.eu> In-Reply-To: <53D20E5B.9070501@monstr.eu> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 25.07.2014 09:59, schrieb Michal Simek: > On 07/25/2014 01:18 AM, Sören Brinkmann wrote: >> On Fri, 2014-07-25 at 01:00AM +0200, Andreas Färber wrote: >>> Prepare SPI0 and SPI1 while at it. > > Patch subject is incorrect. You are adding SPI and QSPI. Yes, it originally added only QSPI, but I considered it a good deed to add SPI as well while already reading that part of the TRM. :) >>> >>> Signed-off-by: Andreas Färber --- v2: New >>> >>> arch/arm/boot/dts/zynq-7000.dtsi | 37 >>> +++++++++++++++++++++++++++++++++++ >>> arch/arm/boot/dts/zynq-parallella.dts | 4 ++++ 2 files >>> changed, 41 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi >>> b/arch/arm/boot/dts/zynq-7000.dtsi index 8fd826a..eed3df0 >>> 100644 --- a/arch/arm/boot/dts/zynq-7000.dtsi +++ >>> b/arch/arm/boot/dts/zynq-7000.dtsi @@ -122,6 +122,30 @@ >>> interrupts = <0 50 4>; }; >>> >>> + spi0: spi@e0006000 { + compatible = "xlnx,zynq-spi-r1p6"; >>> + reg = <0xe0006000 0x1000>; + status = "disabled"; + >>> interrupt-parent = <&intc>; + interrupts = <0 26 4>; + >>> clocks = <&clkc 25>, <&clkc 34>; + clock-names = "ref_clk", >>> "pclk"; + #address-cells = <1>; + #size-cells = <0>; + }; >>> + + spi1: spi@e0007000 { + compatible = >>> "xlnx,zynq-spi-r1p6"; + reg = <0xe0007000 0x1000>; + status >>> = "disabled"; + interrupt-parent = <&intc>; + interrupts = >>> <0 49 4>; + clocks = <&clkc 26>, <&clkc 35>; + clock-names >>> = "ref_clk", "pclk"; + #address-cells = <1>; + #size-cells >>> = <0>; + }; + >> Until here things look good. >> >>> gem0: ethernet@e000b000 { compatible = "cdns,gem"; reg = >>> <0xe000b000 0x4000>; @@ -140,6 +164,19 @@ clock-names = "pclk", >>> "hclk", "tx_clk"; }; >>> >>> + qspi: qspi@e000d000 { + compatible = >>> "xlnx,zynq-spi-r1p6"; + reg = <0xe000d000 0x1000>; + status >>> = "disabled"; + interrupt-parent = <&intc>; + interrupts = >>> <0 19 4>; + clocks = <&clkc 10>, <&clkc 43>; + clock-names >>> = "ref_clk", "pclk"; + num-cs = <1>; + #address-cells = >>> <1>; + #size-cells = <0>; + }; + >> I'm not sure what the status of this driver is. I think QSPI is >> still under review on the mailing lists and I don't think we >> should add this yet. > > Driver for qspi is not in the mainline yet but it doesn't mean that > this fragment won't work. Harini: Can you please correct me if I am > wrong? It did seem to find the flash chip (cf. parallella-next branch), but I didn't find a driver capable of handling its ID. The downstream tree was using m25p80; I tried both micron,n25q128a11 and ...a13 based on U-Boot output. > I would prefer to send two separate patches. Will do. > 1. just add SPI to zynq As I don't have any of the other Zynq boards, can you please advise whether either of them should be enabled for some board? > 2. if Harini confirms that it is working I think that make sense to > enable at least simple mode for qspi. That's why not a problem to > add it too. It means qspi patch with enabling for your board as > second patch. Thanks, Andreas - -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJT0hiHAAoJEPou0S0+fgE/DQwP/1zkv0tkOemDedPDa9dVu/77 0Qc9LTsbBsbn6STakd2z1+Iz2qoy4dePjsGd3hYVgHV6S6MnEiSDTqKjGXmX4Dqu ALxksCLi0wezlQuEN2H110eivMGJ8DBz0qCq0t1acN5Y4YhF9tiCNQARF6XoAwcK 6FtGic/qVC92byGosbD4Y/SvZpJPuk+gACyIhUYEJTS/jKwB68jm5pZZbdGrVsB+ H4B9tGc+qs4bumdmbzxPXp66HyOqKsfRT0P/S6N0nvkqvNaWyM+MAmB4VDW3dnJJ 2ApbNJaPCoKtMHTQ2vnWstOVM4smsYJsszBF1zBIwUYgwW4q2Nv3vvjI23746m+x gq7Tlqa5yIuPe/9+f6ek4dbZWQ7Zj+xw68taLvFkw9+4HvFd9qul/BxryFGTkErH mZkEuQqTq1oppLGS+2ld+/VXt452UKF80Potra/Qt6D/LUA2UBcEIjoLpYxndjqz 3QrVNsw625LCyvJdYovO3FLHJ69U9VyZ4/8edDQzVvhD6/pcQp75W6mchWkxGnyS jZVwKsIKVAWC9k6N6ZOLC5A8KOHRGGY5SOOpOLUQkfTviI5r2eAY5CvX8HOqx9s9 +tVphTMSLc5rC26ePdMwqAWbax4xt1kmWSiSUZ8cOnKvaUpWEPsAfQNMDsBfWiLN aMQyrzdYs+nuCoIksVfN =h5eC -----END PGP SIGNATURE----- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/