Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760074AbaGYLsO (ORCPT ); Fri, 25 Jul 2014 07:48:14 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:60917 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbaGYLsN (ORCPT ); Fri, 25 Jul 2014 07:48:13 -0400 From: Michael Olbrich To: Thierry Reding , Bryan Wu , Lee Jones , Alexandre Courbot Cc: linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Michael Olbrich Subject: [PATCH v2] pwm-backlight: fix probing from device-tree without enable-gpios Date: Fri, 25 Jul 2014 13:47:21 +0200 Message-Id: <1406288841-23140-1-git-send-email-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.0.1 In-Reply-To: <1406284115-489-1-git-send-email-m.olbrich@pengutronix.de> References: <1406284115-489-1-git-send-email-m.olbrich@pengutronix.de> X-SA-Exim-Connect-IP: 2001:6f8:1178:2:a236:9fff:fe00:814 X-SA-Exim-Mail-From: mol@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 257462dbf3ed ("pwm-backlight: switch to gpiod interface") enable_gpio is no longer set and remains 0 when probing from device-tree. This is a valid gpio number. With no enable-gpios specified in the device-tree this is used and probing fails with: pwm-backlight lcd-backlight.3: failed to request GPIO#0: -16 Fix this by setting enable_gpio to -1 which is not a valid gpio number. Signed-off-by: Michael Olbrich --- Sorry, I sent the wrong version. This one actually compiles. Michael drivers/video/backlight/pwm_bl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 38ca88b..e7e43cd 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -211,6 +211,7 @@ static int pwm_backlight_probe(struct platform_device *pdev) dev_err(&pdev->dev, "failed to find platform data\n"); return ret; } + defdata.enable_gpio = -1; data = &defdata; } -- 2.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/