Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751139AbaGZIFG (ORCPT ); Sat, 26 Jul 2014 04:05:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51011 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbaGZIFA (ORCPT ); Sat, 26 Jul 2014 04:05:00 -0400 Date: Sat, 26 Jul 2014 09:13:12 +0100 From: Alexander Gordeev To: linux-kernel@vger.kernel.org Cc: Naresh Kumar Inna , Arvind Bhushan , linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 RESEND 05/23] csiostor: Remove superfluous call to pci_disable_msix() Message-ID: <20140726081311.GC21129@agordeev.usersys.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 16, 2014 at 08:05:09PM +0200, Alexander Gordeev wrote: > There is no need to call pci_disable_msix() in case > the previous call to pci_enable_msix() failed Hi Naresh, Arvind, Could you please review csiostor patches in this series? Thanks! > Signed-off-by: Alexander Gordeev > Cc: Naresh Kumar Inna > Cc: Arvind Bhushan > Cc: linux-scsi@vger.kernel.org > Cc: linux-pci@vger.kernel.org > --- > drivers/scsi/csiostor/csio_isr.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/csiostor/csio_isr.c b/drivers/scsi/csiostor/csio_isr.c > index 7ee9777..91ba91d 100644 > --- a/drivers/scsi/csiostor/csio_isr.c > +++ b/drivers/scsi/csiostor/csio_isr.c > @@ -529,10 +529,8 @@ csio_enable_msix(struct csio_hw *hw) > csio_reduce_sqsets(hw, cnt - extra); > } > } else { > - if (rv > 0) { > - pci_disable_msix(hw->pdev); > + if (rv > 0) > csio_info(hw, "Not using MSI-X, remainder:%d\n", rv); > - } > > kfree(entries); > return -ENOMEM; > -- > 1.7.7.6 > -- Regards, Alexander Gordeev agordeev@redhat.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/