Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbaGZK04 (ORCPT ); Sat, 26 Jul 2014 06:26:56 -0400 Received: from mail-oa0-f41.google.com ([209.85.219.41]:52715 "EHLO mail-oa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750732AbaGZK0y (ORCPT ); Sat, 26 Jul 2014 06:26:54 -0400 MIME-Version: 1.0 In-Reply-To: <20140724173613.GA2203@udknight> References: <1406150427-26077-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20140724173613.GA2203@udknight> From: Rickard Strandqvist Date: Sat, 26 Jul 2014 12:19:17 +0200 Message-ID: Subject: Re: [PATCH v2] video: fbdev: uvesafb.c: Added additional error checking To: Wang YanQing , Rickard Strandqvist , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Jingoo Han , David Fries , Greg Kroah-Hartman , Joe Perches , Linux Fbdev development list , "linux-kernel@vger.kernel.org" , Pavel Machek Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-07-24 19:36 GMT+02:00 Wang YanQing : > On Wed, Jul 23, 2014 at 11:20:27PM +0200, Rickard Strandqvist wrote: >> Variable was assigned a value that is never used. >> Now the variable is used, and the function returns if a call to >> uvesafb_exec() returns a error. > > Because the only user of uvesafb_vbe_getpmi in uvesafb.c > don't check its return value, it should do the check indeed, > so maybe below change is better: > > - if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) { > + if (err || (task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) { > par->pmi_setpal = par->ypan = 0; > } > > Or we check uvesafb_vbe_getpmi's return value, then the code will looks like below: > > if (uvesafb_vbe_getpmi(task, par)) > par->pmi_setpal = par->ypan = 0; Hi Sure, I saw that much of the other code using something like: if (err || ...) But this whole discussion start with that you wished it would return the error, and then error code I assumed? Ok, but something like this then? err = uvesafb_exec(task); if (err) { par->pmi_setpal = par->ypan = 0; return err; } Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/