Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751310AbaGZNmw (ORCPT ); Sat, 26 Jul 2014 09:42:52 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44919 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbaGZNmt (ORCPT ); Sat, 26 Jul 2014 09:42:49 -0400 Message-Id: <1406382166.19420.145911853.784D75D0@webmail.messagingengine.com> X-Sasl-Enc: SeFTPauoWqEjcNIZReTK6rnx79wBbMHm0Jsuj0YoqoiL 1406382166 From: Hannes Frederic Sowa To: Jun Zhao Cc: "David S. Miller" , Cong Wang , Pravin B Shelar , Nicolas Dichtel , stephen hemminger , Tom Herbert , netdev@vger.kernel.org, Francesco Fusco , Veaceslav Falico , Duan Jiong , Jiri Pirko , David Stevens , Or Gerlitz , Daniel Borkmann , linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-36a9b403 In-Reply-To: <1406334557.5276.13.camel@popy-debian> References: <1406306339-16151-1-git-send-email-mypopydev@gmail.com> <1406330697.989.145785925.1CA960AF@webmail.messagingengine.com> <1406334557.5276.13.camel@popy-debian> Subject: Re: [PATCH 1/1] neighbour : fix ndm_type type error issue Date: Sat, 26 Jul 2014 15:42:46 +0200 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Jul 26, 2014, at 02:29, Jun Zhao wrote: > On Sat, 2014-07-26 at 01:24 +0200, Hannes Frederic Sowa wrote: > > On Fri, Jul 25, 2014, at 18:38, Jun Zhao wrote: > > > ndm_type means L3 address type, in neighbour proxy and vxlan, it's > > > RTN_UNICAST. > > > NDA_DST is for netlink TLV type, hence it's not right value in this > > > context. > > > > The value of NDA_DST == RTN_UNICAST, otherwise we couldn't do this > > change as it would alter e.g. arpd behavior. > > > > Acked-by: Hannes Frederic Sowa > > > > Thanks, > > Hannes > > But I think NDA_DST/RTN_UNICAST have different means in this context, > even though the value of NDA_DST == RTN_UNICAST. > > For arp proxy/NDP proxy context, ndm_type means the peer L3 address, > so RTN_UNICAST is the right value. For vxlan have similar semantic for > remote ip. > > BTW: In the source code, implicit think NDA_DST == RTN_UNICAST maybe > not a good idea when we don't have a comment or the other explain. I am totally with you and think your change is good, that's why I also gave my ack to your patch. My comment above was about my concerns regarding making a user space visible change, which in the end could alter the behavior of already existing software. Developers maybe have debugged code and seen some different value being propagated from the kernel and this software could now break if we would change the value after all those years. Bye, Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/