Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752210AbaG1LKg (ORCPT ); Mon, 28 Jul 2014 07:10:36 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:37840 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbaG1LKd (ORCPT ); Mon, 28 Jul 2014 07:10:33 -0400 Date: Mon, 28 Jul 2014 13:10:31 +0200 From: Pavel Machek To: Randy Dunlap Cc: Rickard Strandqvist , Pali =?iso-8859-1?Q?Roh=E1r?= , Stefan Weil , Jiri Kosina , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, trivial@kernel.org Subject: [PATCHv2] Documentation: laptops: freefall.c: Fix missing null-termination Message-ID: <20140728111031.GA17250@amd.pavel.ucw.cz> References: <1406472043-12272-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <53D58550.6040205@infradead.org> <20140728102040.GA16495@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140728102040.GA16495@amd.pavel.ucw.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devname is automatic variable, so it may not contain 0 at the last position. Reported-by: Rickard Strandqvist Signed-off-by: Pavel Machek diff --git a/Documentation/laptops/freefall.c b/Documentation/laptops/freefall.c index aab2ff0..93a7ebf 100644 --- a/Documentation/laptops/freefall.c +++ b/Documentation/laptops/freefall.c @@ -29,7 +29,8 @@ static const char app_name[] = "FREE FALL"; static int set_unload_heads_path(char *device) { - char devname[64]; + /* static for zero termination */ + static char devname[64]; if (strlen(device) <= 5 || strncmp(device, "/dev/", 5) != 0) return -EINVAL; -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/