Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbaG1PMw (ORCPT ); Mon, 28 Jul 2014 11:12:52 -0400 Received: from mx0a-0016ce01.pphosted.com ([67.231.148.157]:12656 "EHLO mx0a-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbaG1PMv convert rfc822-to-8bit (ORCPT ); Mon, 28 Jul 2014 11:12:51 -0400 From: Yuval Mintz To: "Luis R. Rodriguez" , "gregkh@linuxfoundation.org" CC: linux-kernel , "Luis R. Rodriguez" , Tetsuo Handa , Joseph Salisbury , Kay Sievers , One Thousand Gnomes , "Tim Gardner" , Pierre Fersing , Andrew Morton , "Oleg Nesterov" , Benjamin Poirier , "Nagalakshmi Nandigama" , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , Hariprasad S , Santosh Rastapur , "MPT-FusionLinux.pdl@avagotech.com" , linux-scsi , netdev Subject: RE: [PATCH 1/3] driver core: enable drivers to use deferred probe from init Thread-Topic: [PATCH 1/3] driver core: enable drivers to use deferred probe from init Thread-Index: AQHPqnEWy20DxK5pzkqD80N0dwzvZJu1lkPA Date: Mon, 28 Jul 2014 15:12:11 +0000 Message-ID: References: <1406558067-25308-1-git-send-email-mcgrof@do-not-panic.com> In-Reply-To: <1406558067-25308-1-git-send-email-mcgrof@do-not-panic.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.4.10] disclaimer: bypass Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5600 definitions=7512 signatures=670489 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1407280175 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int __driver_probe_device(struct device_driver *drv, struct > +device *dev) { > + if (drv->delay_probe && !dev->init_delayed_probe) { > + dev_info(dev, "Driver %s requests probe deferral on init\n", > + drv->name); > + dev->init_delayed_probe = true; > + driver_deferred_probe_add(dev); > + return -EPROBE_DEFER; > + } > + > + return really_probe(dev, drv); > +} Perhaps this is a silly question, but what guarantees that the deferred probe list will actually be triggered, e.g., in case the delayed device is the last device in the system? [From drivers/base/dd.c - "A successful driver probe will trigger moving all devices from the pending to the active list so that the workqueue will eventually retry them] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/