Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751841AbaG1R7N (ORCPT ); Mon, 28 Jul 2014 13:59:13 -0400 Received: from mail-ie0-f179.google.com ([209.85.223.179]:46953 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751710AbaG1R7I (ORCPT ); Mon, 28 Jul 2014 13:59:08 -0400 MIME-Version: 1.0 In-Reply-To: <20140728144608.7d9ac736@canb.auug.org.au> References: <20140728144608.7d9ac736@canb.auug.org.au> From: Sonny Rao Date: Mon, 28 Jul 2014 10:58:47 -0700 X-Google-Sender-Auth: 274bqCYkHEf-Zc4mqRlxzfnuaUM Message-ID: Subject: Re: linux-next: build failure after merge of the mmc-uh tree To: Stephen Rothwell Cc: Ulf Hansson , linux-next@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 27, 2014 at 9:46 PM, Stephen Rothwell wrote: > Hi Ulf, > > After merging the mmc-uh tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > drivers/mmc/host/dw_mmc.c: In function 'dw_mci_reset': > drivers/mmc/host/dw_mmc.c:2262:3: error: implicit declaration of function 'dw_mci_idmac_reset' [-Werror=implicit-function-declaration] > dw_mci_idmac_reset(host); > ^ Hi, sorry about that. It looks like it fails to build when CONFIG_MMC_DW_IDMAC is not set. I changed that bit of code from using #ifdef to using just C if statement, but I think in this case the function being called doesn't exist when CONFIG_MMC_DW_IDMAC is not set, so that was incorrect and we should go back to using something like: #if IS_ENABLED(CONFIG_MMC_DW_IDMAC) /* It is also recommended that we reset and reprogram idmac */ dw_mci_idmac_reset(host); #endif Ulf, I can respin the patch if you'd like or feel free to fix it yourself too. Thanks. > > Caused by commit 25f7dadbd982 ("mmc: dw_mmc: change to use recommended > reset procedure"). > > I have used the mmc-uh tree from next-20140725 for today. > -- > Cheers, > Stephen Rothwell sfr@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/