Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbaG1Ts4 (ORCPT ); Mon, 28 Jul 2014 15:48:56 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:43580 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbaG1Tsy (ORCPT ); Mon, 28 Jul 2014 15:48:54 -0400 MIME-Version: 1.0 In-Reply-To: References: <1406572110-26823-1-git-send-email-mcgrof@do-not-panic.com> <1406572110-26823-3-git-send-email-mcgrof@do-not-panic.com> <20140728185538.GB17609@kroah.com> From: "Luis R. Rodriguez" Date: Mon, 28 Jul 2014 12:48:32 -0700 X-Google-Sender-Auth: o6_bfzid8MPP0bjQsAymyl_Q14Q Message-ID: Subject: Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init To: Greg KH , Santosh Rastapur , Hariprasad S Cc: Takashi Iwai , "linux-kernel@vger.kernel.org" , Tetsuo Handa , Joseph Salisbury , Kay Sievers , One Thousand Gnomes , Tim Gardner , Pierre Fersing , Andrew Morton , Oleg Nesterov , Benjamin Poirier , Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , MPT-FusionLinux.pdl@avagotech.com, Linux SCSI List , "netdev@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH wrote: >> So, what drivers are having problems in their init sequence, and why >> aren't they using async firmware loading? > > Fixing drivers is one thing, fixing drivers *now* because *now* > drivers are failing due to a regression is another thing and that's > what we have now so lets just be clear on that. The 30 second rule is > a major driver requirement change and it should not be taken slightly, > all of a sudden this is a new requirement but you won't know that > unless you're reading these threads or hit an issue. That's an issue > in itself. > > The cxgb4: driver is an example where although I did propose patches > to use asynch firmware loading the entire registration of the > netdevice would need to be changed as well in order to get this right. > In short we have to scramble now to first identify drivers that have > long init sequences and then fix. There's an assumption that we can > easily fix drivers, this can take time. This series, although does > take advantage of a kernel interface for other uses, lets us identify > these drivers on the kernel ring buffer, so we can go and address > fixing them with time. Another thing that came up during asynch firmware review / integration on cxgb4 was that it would not be the only thing that would need to be fixed, the driver also has a ton of ports and at least as per my review the proper fix would be to use platform regiister stuff. It is a major rewrite of the driver but an example of a driver that needs quite a bit of work to meet this new 30 second driver requirement. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/