Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbaG1XaZ (ORCPT ); Mon, 28 Jul 2014 19:30:25 -0400 Received: from cmexedge1.ext.emulex.com ([138.239.224.99]:31074 "EHLO CMEXEDGE1.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbaG1XaW convert rfc822-to-8bit (ORCPT ); Mon, 28 Jul 2014 19:30:22 -0400 From: Jayamohan Kallickal To: Alexander Gordeev , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() Thread-Topic: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() Thread-Index: AQHPqKeuf60TE+rXl02KrzAcQagVepu2I+dQ Date: Mon, 28 Jul 2014 23:29:51 +0000 Message-ID: <37724B2049F71D4C9B086F99DDB2DE11571FB4AC@CMEXMB1.ad.emulex.com> References: <20140726080842.GB21129@agordeev.usersys.redhat.com> In-Reply-To: <20140726080842.GB21129@agordeev.usersys.redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [138.239.46.127] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -----Original Message----- From: Alexander Gordeev [mailto:agordeev@redhat.com] Sent: Saturday, July 26, 2014 1:09 AM To: linux-kernel@vger.kernel.org; Jayamohan Kallickal Subject: Re: [PATCH v2 RESEND 01/23] be2iscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() On Wed, Jul 16, 2014 at 08:05:05PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers using these > two interfaces need to be updated to use the new > pci_enable_msi_range() or pci_enable_msi_exact() and > pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Hi Jayamohan, Could you please review this patch? Thanks! > Signed-off-by: Alexander Gordeev > --- > drivers/scsi/be2iscsi/be_main.c | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/be2iscsi/be_main.c > b/drivers/scsi/be2iscsi/be_main.c index 56467df..1f63169 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -5278,12 +5278,10 @@ static void beiscsi_msix_enable(struct beiscsi_hba *phba) > for (i = 0; i <= phba->num_cpus; i++) > phba->msix_entries[i].entry = i; > > - status = pci_enable_msix(phba->pcidev, phba->msix_entries, > - (phba->num_cpus + 1)); > + status = pci_enable_msix_exact(phba->pcidev, phba->msix_entries, > + phba->num_cpus + 1); > if (!status) > phba->msix_enabled = true; > - > - return; > } > > static void be_eqd_update(struct beiscsi_hba *phba) > -- > 1.7.7.6 > Looks Good. Acked-by: Jayamohan Kallickal -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/