Message-ID: <1406599159.5285.12.camel@joe-AO725>
Subject: Re: [PATCH] Staging: bcm: Bcmchar.c: remove else statement after
 return
From: Joe Perches <joe@perches.com>
To: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        gregkh@linuxfoundation.org, klmckinney1@gmail.com,
        mail@beyermatthias.de
Date: Mon, 28 Jul 2014 18:59:19 -0700
In-Reply-To: <1406592554-9519-1-git-send-email-mopsfelder@gmail.com>
References: <1406592554-9519-1-git-send-email-mopsfelder@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 2014-07-28 at 21:09 -0300, Murilo Opsfelder Araujo wrote:
> This patch makes checkpatch.pl script happier by fixing all warnings
> related to else statement after break or return.
[]
> diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
[]
> @@ -561,10 +561,10 @@ static int bcm_char_ioctl_gpio_set_request(void __user *argp,
>  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, OSAL_DBG, DBG_LVL_ALL,
>  				"GPIO_MODE_REGISTER read failed");
>  		return Status;
> -	} else {
> -		Status = STATUS_SUCCESS;
>  	}
>  
> +	Status = STATUS_SUCCESS;

This set of Status is unnecessary

>  	/* Set the gpio mode register to output */
>  	*(UINT *)ucResetValue |= (1<<uiBit);
>  	Status = wrmaltWithLock(Adapter, GPIO_MODE_REGISTER,

as it's immediately overwritten.

> @@ -669,10 +669,10 @@ static int bcm_char_ioctl_gpio_status_request(void __user *argp,
>  		Status = bytes;
>  		BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
>  				"RDM Failed\n");
> -		return Status;
>  	} else {
>  		Status = STATUS_SUCCESS;
>  	}
> +
>  	return Status;

	return STATUS_SUCCESS;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/