Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975AbaG2Isp (ORCPT ); Tue, 29 Jul 2014 04:48:45 -0400 Received: from service87.mimecast.com ([91.220.42.44]:44827 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbaG2Ism convert rfc822-to-8bit (ORCPT ); Tue, 29 Jul 2014 04:48:42 -0400 Message-ID: <53D76006.4040105@arm.com> Date: Tue, 29 Jul 2014 09:49:10 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Graeme Gregory , "hanjun.guo@linaro.org" , Catalin Marinas , "Rafael J. Wysocki" , Mark Rutland CC: Sudeep Holla , Arnd Bergmann , "grant.likely@linaro.org" , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Al Stone , Tomasz Nowicki Subject: Re: [PATCH 01/19] ARM64 / ACPI: Get RSDP and ACPI boot-time tables References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-2-git-send-email-hanjun.guo@linaro.org> <53D69678.20002@arm.com> <53D6D391.8090907@linaro.org> In-Reply-To: <53D6D391.8090907@linaro.org> X-OriginalArrivalTime: 29 Jul 2014 08:48:37.0726 (UTC) FILETIME=[E38567E0:01CFAB09] X-MC-Unique: 114072909484012201 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/14 23:49, Graeme Gregory wrote: > > On 28/07/2014 19:29, Sudeep Holla wrote: >> >> >> On 24/07/14 14:00, Hanjun Guo wrote: >>> From: Al Stone >>> >>> As we want to get ACPI tables to parse and then use the information >>> for system initialization, we should get the RSDP (Root System >>> Description Pointer) first, it then locates Extended Root Description >>> Table (XSDT) which contains all the 64-bit physical address that >>> pointer to other boot-time tables. >>> >>> Introduce acpi.c and its related head file in this patch to provide >>> fundamental needs of extern variables and functions for ACPI core, >>> and then get boot-time tables as needed. >>> - asm/cpu.h need for ACPI core and will be updated in the future to >>> add definitions for arch_(un)register_cpu which are required for >>> ACPI based physical CPU hotplug; >>> - asm/acenv.h for arch specific ACPICA environments and >>> implementation; >>> - asm/acpi.h for arch specific variables and functions needed by >>> ACPI driver core; >>> - acpi.c for ARM64 related ACPI implementation for ACPI driver >>> core; >>> >>> acpi_boot_table_init() is introduced to get RSDP and boot-time tables, >>> it will be called in setup_arch() before paging_init(), so we should >>> use eary_memremap() mechanism here to get the RSDP and all the table >>> pointers. >>> >>> Signed-off-by: Al Stone >>> Signed-off-by: Graeme Gregory >>> Signed-off-by: Tomasz Nowicki >>> Signed-off-by: Hanjun Guo >>> --- >>> arch/arm64/include/asm/acenv.h | 18 ++++++++++ >>> arch/arm64/include/asm/acpi.h | 41 ++++++++++++++++++++++ >>> arch/arm64/include/asm/cpu.h | 11 ++++++ >>> arch/arm64/kernel/Makefile | 1 + >>> arch/arm64/kernel/acpi.c | 76 >>> ++++++++++++++++++++++++++++++++++++++++ >>> arch/arm64/kernel/setup.c | 4 +++ >>> 6 files changed, 151 insertions(+) >>> create mode 100644 arch/arm64/include/asm/acenv.h >>> create mode 100644 arch/arm64/include/asm/acpi.h >>> create mode 100644 arch/arm64/include/asm/cpu.h >>> create mode 100644 arch/arm64/kernel/acpi.c >>> [...] >>> + >>> +/* >>> + * MADT must provide at least one GICC structure >>> + * for GIC initialization, so CPU will be >>> + * always available in MADT on ARM64 >>> + */ >>> +static inline bool acpi_has_cpu_in_madt(void) >>> +{ >>> + return 1; >>> +} >>> + >> >> I don't see the user of this function in the series, it's better to >> remove. Moreover the comment is so misleading. We will have CPU UID >> not the CPU itself in MADT. >> > This is actually required for a patch that is now upstreamed. Comment > should actually say that its checking for the posibility that the CPU > can be initialised from the MADT. Its used from core in crash kernel > case where boot CPU is not necessarily CPU0 like spec demands. > Ah OK, I now see that in Rafael's linux-pm/linux-next. Sorry I might have missed to notice that and I assumed this series is based on mainline. Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/