Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753453AbaG2LdI (ORCPT ); Tue, 29 Jul 2014 07:33:08 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60927 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbaG2LdD (ORCPT ); Tue, 29 Jul 2014 07:33:03 -0400 Date: Tue, 29 Jul 2014 12:32:36 +0100 From: Mark Brown To: Alexandre Belloni Cc: =?utf-8?B?SmnFmcOt?= Prchal , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com, voice.shen@atmel.com Message-ID: <20140729113236.GM17528@sirena.org.uk> References: <20140728122103.GR9532@piout.net> <53D64ADA.1000102@aksignal.cz> <20140728223859.GA3214@piout.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nOkP3B9e3ta8qQbV" Content-Disposition: inline In-Reply-To: <20140728223859.GA3214@piout.net> X-Cookie: 98% lean. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] ARM: at91: spi: request all csgpio in spi probe X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nOkP3B9e3ta8qQbV Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 29, 2014 at 12:38:59AM +0200, Alexandre Belloni wrote: > Mark: maybe it would make sense to do devm_gpio_request_one() in > of_spi_register_master(), after of_get_named_gpio. You need to transition all the drivers doing things manually but yes. As I keep saying all the GPIO handling needs to be completely refactored. > While this solves the particular issue Ji=C5=99=C3=AD is seeing, this wil= l not > solve the case where PA14 (CS0) is not used by the spi driver at all. It > will remained muxed as CS0 and toggle when the spi master needs to > access CS0 until another driver muxes it to something else. I still > believe we should explicitly ask pinctrl to mux them as gpios. I'm just guessing as to what the issue that he's seeing is but isn't this just saying that the board pinmuxing is wrong? If the board doesn't want the pin to be used by the SPI controller it shouldn't be=20 configuring it that way. --nOkP3B9e3ta8qQbV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJT14ZRAAoJELSic+t+oim9sM0P/jmBwEu0CH2FaGSh+517g5R4 KbrixTeEPmC1TlcJ6AKCtCzEW7v6amUpiBOm/8h2w7vcQEVNt4kVAzPwvQDXqmdr IJ36hXXB9VGt1k51u0fW8wBvkl8xu/VzuS3pyuNZTvzjHr6BqJlAve8en4FH4Dk9 qJubrRG/C9HZLUbrD7TvIVtQ8Am01Ip+1LnLVtVGKLdh8Dqy/q3vBR5zbTcJYxMj FBa4mugfAgkUg4SAf9DsxsG0Aj9SO3DZRBSArp2t9uXT6TxKhSbG6jmdZpXHZtF2 bZ7o70qIsuuJ6O5Rn22WoA7WgHmNxN/7uO3hRZg5Xj7zSTlc45ezvaq1tRq72+Xl 61xmHFZxkooB/d4wnlWM0/ukhx9yCCVnKFpG3031rbQ6b1kqVIHUAiEL/sIOd1/b pHA+UXkn0CcpuE0xA2dNH10l3MbH92YU1ow9QgicIai795IZh8bPQGHAp/v3w/4n 0i0dd4LsKNu5G1inBqm5UIr1/KrBDeE0+78u0lHeRNkSRc+LhYZBoxNE4gm6CBMR dQTkqbgLg6yo8SdQywA98uI+gM0NnXTj2rgMnJUbGaw/vKWK1nVef00XDQSsySmN zKISdo2bbGMuLbKY9AOw4Q6DA0HmT1u9o9VzPVAFLaMD50jzEwDctJf+eP793wJ2 EL3kXOpSdZCzCWzES7k1 =lTuD -----END PGP SIGNATURE----- --nOkP3B9e3ta8qQbV-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/