Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753496AbaG2NAL (ORCPT ); Tue, 29 Jul 2014 09:00:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44358 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751143AbaG2NAJ (ORCPT ); Tue, 29 Jul 2014 09:00:09 -0400 Message-ID: <53D79AD3.8020700@suse.de> Date: Tue, 29 Jul 2014 15:00:03 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Javier Martinez Canillas , Doug Anderson CC: "linux-samsung-soc@vger.kernel.org" , Stephan van Schaik , Vincent Palatin , Ben Dooks , Kukjin Kim , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , "moderated list:ARM/SAMSUNG ARM A..." , "open list:OPEN FIRMWARE AND..." , open list Subject: Re: [PATCH v2 3/4] ARM: dts: exynos5250: Fold common ChromeOS parts into Snow References: <1405704009-8430-1-git-send-email-afaerber@suse.de> <1405704009-8430-4-git-send-email-afaerber@suse.de> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier and Doug, Am 25.07.2014 19:02, schrieb Javier Martinez Canillas: > On Fri, Jul 25, 2014 at 6:43 PM, Doug Anderson wrote: >> On Fri, Jul 25, 2014 at 9:35 AM, Javier Martinez Canillas >> wrote: >>> Hello Andreas, >>> >>> On Fri, Jul 18, 2014 at 7:20 PM, Andreas Färber wrote: >>>> >>>> + memory { >>>> + reg = <0x40000000 0x80000000>; >>>> + }; >>>> + >>>> + chosen { >>>> + }; >>>> + >>> >>> Is there a reason for an empty chosen node? Same for the Spring DTS. >> >> I know that the bootloader (U-Boot) fills this in. I'd have to double >> check how the bootloader handles the node not being there to begin >> with. > > Yes, U-Boot fills this but if the node does not exist in the FDT, it > creates one. Take a look at fdt_chosen() in common/fdt_support.c [0]. > > So I think it's better to just remove it since is empty. Hm, in different context it was stated that device trees shouldn't rely on bootloader behavior (for a /memory node on Zynq we ended up specifying the size cell with the real value despite U-Boot overriding it to a lesser value). Can we instead settle on filling this node with defaults? :) bootargs = "console=tty1"; would be my choice for Spring. Would that be applicable for Snow as well? Not sure how to specify that via linux,stdout-path property. I believe this would be a follow-up patch either way. Since there's at least two series out there trying to fiddle with -cros-common.dtsi, including one that drops the slot sub-node of the MMC and one that adds CPU power supply, it would be nice if we can get the -cros-common parts sorted out and applied. Can you ack/review 1-2? Should I squash them in a v3? Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/