Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbaG2NU2 (ORCPT ); Tue, 29 Jul 2014 09:20:28 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48650 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753347AbaG2NUZ (ORCPT ); Tue, 29 Jul 2014 09:20:25 -0400 Date: Tue, 29 Jul 2014 06:20:20 -0700 From: Christoph Hellwig To: Tomas Henzl Cc: Alexander Gordeev , linux-kernel@vger.kernel.org, xjtuwjp@gmail.com, lindar_liu@usish.com, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org, Suresh Thiagarajan Subject: Re: [PATCH v2 RESEND 17/23] pm8001: Fix invalid return when request_irq() failed Message-ID: <20140729132020.GA7714@infradead.org> References: <5ecd9b80f705545c3dc85b2a4ae63a8ac3df8105.1405533479.git.agordeev@redhat.com> <53D79DE2.9000702@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53D79DE2.9000702@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 29, 2014 at 03:13:06PM +0200, Tomas Henzl wrote: > Hi, > patch looks good. > > A correction in pm8001_request_irq might be added too to allow > the INT-X path when pm8001_setup_msix fails, but that is not part > of this fix. There's actually an equivalent fix already in through one of the previous pm8001 updates, so I skipped this one even if it already had an ACK. The following pm8001 applied just fine, though. Take a look, as I've already pushed out the updated drivers branch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/