Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752549AbaG2TJY (ORCPT ); Tue, 29 Jul 2014 15:09:24 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:46452 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbaG2TJW (ORCPT ); Tue, 29 Jul 2014 15:09:22 -0400 MIME-Version: 1.0 In-Reply-To: References: <1406383665-1670-1-git-send-email-rickard_strandqvist@spectrumdigital.se> From: Rickard Strandqvist Date: Tue, 29 Jul 2014 21:09:01 +0200 Message-ID: Subject: Re: [PATCH] block: bsg.c: Cleaning up missing null-terminate in conjunction with strncpy To: Jeff Moyer Cc: FUJITA Tomonori , Jens Axboe , linux-scsi@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-07-28 16:31 GMT+02:00 Jeff Moyer : > Rickard Strandqvist writes: > >> Replacing strncpy with strlcpy to avoid strings that lacks null terminate. >> >> Signed-off-by: Rickard Strandqvist >> --- >> block/bsg.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/bsg.c b/block/bsg.c >> index ff46add..b2688c5 100644 >> --- a/block/bsg.c >> +++ b/block/bsg.c >> @@ -790,7 +790,7 @@ static struct bsg_device *bsg_add_device(struct inode *inode, >> mutex_lock(&bsg_mutex); >> hlist_add_head(&bd->dev_list, bsg_dev_idx_hash(iminor(inode))); >> >> - strncpy(bd->name, dev_name(rq->bsg_dev.class_dev), sizeof(bd->name) - 1); >> + strlcpy(bd->name, dev_name(rq->bsg_dev.class_dev), sizeof(bd->name)); >> dprintk("bound to <%s>, max queue %d\n", >> format_dev_t(buf, inode->i_rdev), bd->max_queue); > > NACK > > The bsg data structure is allocated using kzalloc, so that last byte > will be zero. Hi Sorry.. I did not know bsg_alloc_device used kzalloc, right then everything should be ok. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/