Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755095AbaG3Gue (ORCPT ); Wed, 30 Jul 2014 02:50:34 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33041 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754208AbaG3Guc (ORCPT ); Wed, 30 Jul 2014 02:50:32 -0400 Date: Wed, 30 Jul 2014 08:50:30 +0200 From: Pavel Machek To: Rickard Strandqvist Cc: Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rickard Strandqvist , Jingoo Han , Laurent Pinchart , Rob Clark , Daniel Vetter , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video: fbdev: intelfb: intelfb_i2c.c: Cleaning up variable that is never used Message-ID: <20140730065030.GA8024@amd.pavel.ucw.cz> References: <1404563048-19690-1-git-send-email-rickard_strandqvist@spectrumdigital.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404563048-19690-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 2014-07-05 14:24:08, Rickard Strandqvist wrote: > From: Rickard Strandqvist > > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck Are you sure this is the right fix? Do we need to read the register in case we don't care about return value? > index 3300bd3..4df2f1f 100644 > --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c > +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c > @@ -55,22 +55,20 @@ static void intelfb_gpio_setscl(void *data, int state) > { > struct intelfb_i2c_chan *chan = data; > struct intelfb_info *dinfo = chan->dinfo; > - u32 val; > > OUTREG(chan->reg, (state ? SCL_VAL_OUT : 0) | > SCL_DIR | SCL_DIR_MASK | SCL_VAL_MASK); > - val = INREG(chan->reg); > + INREG(chan->reg); > } -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/