Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751569AbaG3ITr (ORCPT ); Wed, 30 Jul 2014 04:19:47 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:56789 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbaG3ITo (ORCPT ); Wed, 30 Jul 2014 04:19:44 -0400 Message-ID: <1406708378.22788.5.camel@BR9GV9YG.de.ibm.com> Subject: Re: [PATCH] s390: net: qeth_core_main.c: Cleaning up missing null-terminate in conjunction with strncpy From: Ursula Braun To: Rickard Strandqvist Cc: Martin Schwidefsky , Frank Blaschka , linux-s390@vger.kernel.org, linux390@de.ibm.com, Ursula Braun , linux-kernel@vger.kernel.org, Heiko Carstens Date: Wed, 30 Jul 2014 10:19:38 +0200 In-Reply-To: References: <1406385326-3289-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <1406639627.13705.11.camel@BR9GV9YG.de.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14073008-8372-0000-0000-000000B0A4B3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2014-07-29 at 15:21 +0200, Rickard Strandqvist wrote: > > Den 29 jul 2014 15:13 skrev "Ursula Braun" > : > > > > On Sat, 2014-07-26 at 16:35 +0200, Rickard Strandqvist wrote: > > > Replacing strncpy with strlcpy to avoid strings that lacks null > terminate. > > > > > > Signed-off-by: Rickard Strandqvist > > > > --- > > > drivers/s390/net/qeth_core_main.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/s390/net/qeth_core_main.c > b/drivers/s390/net/qeth_core_main.c > > > index f54bec5..ec9b4d7 100644 > > > --- a/drivers/s390/net/qeth_core_main.c > > > +++ b/drivers/s390/net/qeth_core_main.c > > > @@ -5275,7 +5275,7 @@ static int qeth_add_dbf_entry(struct > qeth_card *card, char *name) > > > new_entry = kzalloc(sizeof(struct qeth_dbf_entry), > GFP_KERNEL); > > > if (!new_entry) > > > goto err_dbg; > > > - strncpy(new_entry->dbf_name, name, DBF_NAME_LEN); > > > + strlcpy(new_entry->dbf_name, name, DBF_NAME_LEN); > > > new_entry->dbf_info = card->debug; > > > mutex_lock(&qeth_dbf_list_mutex); > > > list_add(&new_entry->dbf_list, &qeth_dbf_list); > > > > It is guaranteed that the string ch->id always fits into > DBF_NAME_LEN. > > What's in this case the benefit of replacing strncpy() by strlcpy() > > here? > > Hi > > If it is really so! > It can just as well replacing it with strcpy... > > BR > Rickard Strandqvist And what would be the benefit of this change? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/