Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbaG3Kwx (ORCPT ); Wed, 30 Jul 2014 06:52:53 -0400 Received: from mail-qg0-f41.google.com ([209.85.192.41]:39282 "EHLO mail-qg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752106AbaG3Kwv (ORCPT ); Wed, 30 Jul 2014 06:52:51 -0400 MIME-Version: 1.0 In-Reply-To: <20140730085743.GC10301@distanz.ch> References: <1405413956-2772-1-git-send-email-lftan@altera.com> <1405413956-2772-6-git-send-email-lftan@altera.com> <20140730085743.GC10301@distanz.ch> Date: Wed, 30 Jul 2014 18:52:50 +0800 X-Google-Sender-Auth: PCXtfg7QedbmiPJzC0NddhyMqq4 Message-ID: Subject: Re: [PATCH v2 05/29] nios2: Memory management From: Ley Foon Tan To: Tobias Klauser Cc: Geert Uytterhoeven , Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Chung-Lin Tang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 30, 2014 at 4:57 PM, Tobias Klauser wrote: >> >> Any chance you can use mmu.h from asm-generic instead? >> >> It uses a struct with a single "unsigned long end_brk" member (unless >> >> CONFIG_BINFMT_ELF_FDPIC is defined). >> > From asm-generic/mmu.h, it is for nommu implementations. >> > So, I will keep this as it is now. >> >> Right, you have a MMU. >> I got confused by the "Taken from m68knommu" comment, and you still >> only need a single "unsigned long". > > That comment stems from the initial Nios II NOMMU port done by > Microtronix. Since Nios II NOMMU support was dropped for mainline > submission anyhow, it might be better to drop that comment to avoid any > future confusion :) Okay, I will remove these nommu comments. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/