Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753941AbaG3MzT (ORCPT ); Wed, 30 Jul 2014 08:55:19 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:63557 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbaG3MzR (ORCPT ); Wed, 30 Jul 2014 08:55:17 -0400 Date: Wed, 30 Jul 2014 14:55:23 +0200 From: Daniel Vetter To: Benjamin Gaignard Cc: Dave Airlie , Russell King - ARM Linux , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" , Laurent Pinchart Subject: Re: [PATCH v5 00/11] Add DRM for stih4xx platforms Message-ID: <20140730125523.GP4747@phenom.ffwll.local> Mail-Followup-To: Benjamin Gaignard , Dave Airlie , Russell King - ARM Linux , Linux Kernel Mailing List , "dri-devel@lists.freedesktop.org" , "linaro-mm-sig@lists.linaro.org" , Laurent Pinchart References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 3.15.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 30, 2014 at 12:43:33PM +0200, Benjamin Gaignard wrote: > I have push two additional patches on drm_kms_for_next-v7 branch to > make the driver build as a module: > - "gpu: drm: export drm_sysfs_connector_{add,remove} function" Nope, you're using the wrong functions. Instead you should use drm_connector_register/unregister. Please don't just export randome functions without digging into the history a bit. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/