Message-ID: <53D8FB53.3050501@mev.co.uk>
Date: Wed, 30 Jul 2014 15:04:03 +0100
From: Ian Abbott <abbotti@mev.co.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Dan Carpenter <dan.carpenter@oracle.com>
CC: <driverdev-devel@linuxdriverproject.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/19 v2] staging: comedi: amplc_pci230: remove unnecessary
 braces
References: <1406635107-27950-14-git-send-email-abbotti@mev.co.uk> <1406721227-8144-1-git-send-email-abbotti@mev.co.uk> <20140730134153.GJ4856@mwanda>
In-Reply-To: <20140730134153.GJ4856@mwanda>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 2014-07-30 14:41, Dan Carpenter wrote:
> On Wed, Jul 30, 2014 at 12:53:47PM +0100, Ian Abbott wrote:
>> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
>> ---
>> v2: Be less aggressive in brace removal.  Keep them for outer nested
>> 'if's.  Keep them in outer control statements where the inner control
>> statement uses braces.
>
> Really every multi-line indent should have braces for readability.  This
> isn't documented anywhere, but it's normal kernel style and Greg prefers
> it for staging as well but I can't find the URL on google where he
> mentioned that.

With this version of the patch, amplc_pci230.c conforms to that -- as 
long as you don't count comments, or splitting a simple statement across 
multiple lines to fit within 80 columns, e.g.:

			if (foo)
				/* do this */
				bar = baz +
				      qux;

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/