Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754416AbaG3PSb (ORCPT ); Wed, 30 Jul 2014 11:18:31 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:59023 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754029AbaG3PS3 (ORCPT ); Wed, 30 Jul 2014 11:18:29 -0400 Message-ID: <53D90CC4.9070009@cogentembedded.com> Date: Wed, 30 Jul 2014 19:18:28 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kever Yang , heiko@sntech.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rdunlap@infradead.org, linux@arm.linux.org.uk, paulz@synopsys.com, gregkh@linuxfoundation.org, mporter@linaro.org, kishon@ti.com, balbi@ti.com CC: swarren@wwwdotorg.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, addy.ke@rock-chips.com, xjq@rock-chips.com, cf@rock-chips.com, lyz@rock-chips.com, wulf@rock-chips.com, dianders@chromium.org, olof@lixom.net, sonnyrao@chromium.org Subject: Re: [PATCH 2/4] ARM: dts: add rk3288 dwc2 controller support References: <1406683873-18194-1-git-send-email-kever.yang@rock-chips.com> <1406684075-18271-1-git-send-email-kever.yang@rock-chips.com> In-Reply-To: <1406684075-18271-1-git-send-email-kever.yang@rock-chips.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 07/30/2014 05:34 AM, Kever Yang wrote: > rk3288 has two kind of usb controller, this add the dwc2 controller > for otg and host1. > Controller can works with usb PHY default setting and Vbus on. > Signed-off-by: Kever Yang > --- > arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index abc51f5..4309c4f 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -646,5 +646,25 @@ > clock-names = "baudclk", "apb_pclk"; > status = "disabled"; > }; > + > + usb_otg: dwc2@ff580000 { The ePAPR standard [1] says: The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. If appropriate, the name should be one of the following choices: [...] ? usb > + compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb", > + "snps,dwc2"; > + reg = <0xff580000 0x40000>; > + interrupts = ; > + clocks = <&cru HCLK_OTG0>; > + clock-names = "otg"; > + status = "disabled"; > + }; > + > + usb_host1: dwc2@ff540000 { Same here. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/