Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755576AbaG3RWh (ORCPT ); Wed, 30 Jul 2014 13:22:37 -0400 Received: from sabe.cs.wisc.edu ([128.105.6.20]:36633 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754972AbaG3RWf (ORCPT ); Wed, 30 Jul 2014 13:22:35 -0400 Message-ID: <53D929C3.3040709@cs.wisc.edu> Date: Wed, 30 Jul 2014 12:22:11 -0500 From: Mike Christie User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130917 Thunderbird/17.0.9 MIME-Version: 1.0 To: Christoph Hellwig CC: poma , James Bottomley , Vladimir Davydov , Linux Kernel list , Christoph Lameter , Mailing-List fedora-kernel , Paolo Bonzini , linux-scsi@vger.kernel.org Subject: Re: WARNING: CPU: 1 PID: 495 at mm/slab_common.c:69 kmem_cache_create+0x1a9/0x330() References: <53C8DF7F.5060707@gmail.com> <53C8FD95.5020302@gmail.com> <20140718132104.GK27940@esperanza> <20140718141747.GA23272@lst.de> <53C97D34.5040707@gmail.com> <1405714046.30262.10.camel@dabdike.int.hansenpartnership.com> <20140719164454.GA24530@lst.de> <53CCDFC3.5010802@gmail.com> <20140726162102.GA7126@lst.de> In-Reply-To: <20140726162102.GA7126@lst.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/26/2014 11:21 AM, Christoph Hellwig wrote: > Here's a formal one. > > James, can I get your signoff for it? > > Vladimir, can I get a reviewed-by from you (or anyone else)? > > --- > From 73b1034ab1418e2dea75ccf642bc85c728b57313 Mon Sep 17 00:00:00 2001 > From: James Bottomley > Date: Sat, 26 Jul 2014 12:21:26 -0400 > Subject: scsi: use short driver name for per-driver cmd slab caches > > hostt->name might contain space, so use the ->proc_name short name instead > when creating per-driver command slabs. > > Reported-by: Vladimir Davydov > Tested-by: Vladimir Davydov > --- > drivers/scsi/scsi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c > index 33318f5..df33060 100644 > --- a/drivers/scsi/scsi.c > +++ b/drivers/scsi/scsi.c > @@ -365,8 +365,8 @@ scsi_alloc_host_cmd_pool(struct Scsi_Host *shost) > if (!pool) > return NULL; > > - pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->name); > - pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->name); > + pool->cmd_name = kasprintf(GFP_KERNEL, "%s_cmd", hostt->proc_name); > + pool->sense_name = kasprintf(GFP_KERNEL, "%s_sense", hostt->proc_name); > if (!pool->cmd_name || !pool->sense_name) { > scsi_free_host_cmd_pool(pool); > return NULL; Some drivers like qla2xxx do not set proc_name. I think if 2 drivers like that are loaded then you will hit some other warns/bugs in the kmem cache setup code right? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/