Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755826AbaG3SVK (ORCPT ); Wed, 30 Jul 2014 14:21:10 -0400 Received: from service87.mimecast.com ([91.220.42.44]:33302 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755776AbaG3SVG convert rfc822-to-8bit (ORCPT ); Wed, 30 Jul 2014 14:21:06 -0400 Message-ID: <53D937B5.5040404@arm.com> Date: Wed, 30 Jul 2014 19:21:41 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Hanjun Guo , Catalin Marinas , "Rafael J. Wysocki" , Mark Rutland CC: Sudeep Holla , "graeme.gregory@linaro.org" , Arnd Bergmann , "grant.likely@linaro.org" , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Tomasz Nowicki Subject: Re: [PATCH 08/19] ACPI / table: Print GIC information when MADT is parsed References: <1406206825-15590-1-git-send-email-hanjun.guo@linaro.org> <1406206825-15590-9-git-send-email-hanjun.guo@linaro.org> In-Reply-To: <1406206825-15590-9-git-send-email-hanjun.guo@linaro.org> X-OriginalArrivalTime: 30 Jul 2014 18:21:04.0285 (UTC) FILETIME=[061424D0:01CFAC23] X-MC-Unique: 114073019210404001 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/07/14 14:00, Hanjun Guo wrote: > When MADT is parsed, print GIC information to make the boot > log look pretty. > > Signed-off-by: Hanjun Guo > Signed-off-by: Tomasz Nowicki > --- > drivers/acpi/tables.c | 39 ++++++++++++++++++++++++++++++++++++++- > 1 file changed, 38 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index 6d5a6cd..8bb8159 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -183,6 +183,44 @@ void acpi_table_print_madt_entry(struct acpi_subtable_header *header) > } > break; > > + case ACPI_MADT_TYPE_GENERIC_INTERRUPT: > + { > + struct acpi_madt_generic_interrupt *p = > + (struct acpi_madt_generic_interrupt *)header; > + pr_info("GICC (acpi_id[0x%04x] cpu_address[0x%08llx] MPDIR[0x%llx] %s)\n", What exactly does cpu_address mean ? Better s/cpu_address/address > + p->uid, p->base_address, p->mpidr, > + (p->flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled"); > + > + } > + break; > + > + case ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR: > + { > + struct acpi_madt_generic_distributor *p = > + (struct acpi_madt_generic_distributor *)header; > + pr_info("GIC Distributor (id[0x%04x] address[0x%08llx] gsi_base[%d])\n", > + p->gic_id, p->base_address, p->global_irq_base); > + } > + break; > + > + case ACPI_MADT_TYPE_GIC_MSI_FRAME: > + { > + struct acpi_madt_gic_msi_frame *p = > + (struct acpi_madt_gic_msi_frame *)header; > + pr_info("GIC MSI Frame (address[0x%08llx] msi_fame_id[%d])\n", > + p->base_address, p->gic_msi_frame_id); > + } > + break; > + > + case ACPI_MADT_TYPE_GIC_REDISTRIBUTOR: > + { > + struct acpi_madt_gic_redistributor *p = > + (struct acpi_madt_gic_redistributor *)header; > + pr_info("GIC Redistributor (address[0x%08llx] region_size[0x%x])\n", > + p->base_address, p->region_size); > + } > + break; > + You may need to rework on the variable names when you rebase on ACPICA 20140724 Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/