Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbaGaAFK (ORCPT ); Wed, 30 Jul 2014 20:05:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42908 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbaGaAFJ (ORCPT ); Wed, 30 Jul 2014 20:05:09 -0400 Date: Wed, 30 Jul 2014 17:04:40 -0700 From: Greg KH To: Fernando =?iso-8859-1?Q?Apestegu=EDa?= Cc: Guillaume Clement , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: vt6655: staticfy variable Message-ID: <20140731000440.GA17081@kroah.com> References: <20140730191638.GA5493@pleinair.baobob.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 30, 2014 at 11:20:49PM +0200, Fernando Apestegu?a wrote: > On Wed, Jul 30, 2014 at 9:16 PM, Guillaume Clement wrote: > > Hello, > > > >> Add static to variable. > >> Signed-off-by: Fernando Apesteguia > >> --- > >> drivers/staging/vt6655/ioctl.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/staging/vt6655/ioctl.c > >> b/drivers/staging/vt6655/ioctl.c > >> index 65e5933..cc6e47b 100644 > >> --- a/drivers/staging/vt6655/ioctl.c > >> +++ b/drivers/staging/vt6655/ioctl.c > >> @@ -41,7 +41,7 @@ > >> static int msglevel = MSG_LEVEL_INFO; > >> > >> #ifdef WPA_SM_Transtatus > >> -SWPAResult wpa_Result; > >> +static SWPAResult wpa_Result; > >> #endif > > > > This changes breaks the compilation (actually the linking). wpa_Result > > is actually used in device_main.c in device_open with the following: > > Argh... sorry, I missed that. ALWAYS test-build your patches, don't make me be your first tester... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/