Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755947AbaGaCFT (ORCPT ); Wed, 30 Jul 2014 22:05:19 -0400 Received: from mail-vc0-f173.google.com ([209.85.220.173]:34313 "EHLO mail-vc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbaGaCFR (ORCPT ); Wed, 30 Jul 2014 22:05:17 -0400 MIME-Version: 1.0 In-Reply-To: References: <1406752954-26158-1-git-send-email-xerofoify@gmail.com> Date: Wed, 30 Jul 2014 22:05:16 -0400 Message-ID: Subject: Re: [PATCH] Remove certain calls for releasing page cache From: Nick Krause To: Dave Airlie Cc: Chris Mason , Josef Bacik , "linux-btrfs@vger.kernel.org SYSTEM list:BTRFS FILE" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 30, 2014 at 7:30 PM, Dave Airlie wrote: >> This patch removes the lines for releasing the page cache in certain >> files as this may aid in perfomance with writes in the compression >> rountines of btrfs. Please note that this patch has not been tested >> on my own hardware due to no compression based btrfs volumes of my >> own. >> > > For all that is sacred, STOP. > > Go and do something else, you are wasting people's valuable time, > > Don't send any patches you haven't tested ever. If you aren't capable > of setting up a VM to run compressed btrfs volumes in, what makes you > think you can patch the code. > > This isn't how you learn to be a kernel developer by wasting other > kernel developers time, if you can't work out why releasing the page cache > is necessary then don't send the patch until you have spent the time > understanding what the page cache is. > > I know you'll just ignore this, and keep on trucking just like you ignored > the other messages from Stephen before. > > But if you want to work on the kernel, this isn't the way to do it, and > nobody will ever take a patch from you seriously if you continue in this > fashion. > > Dave. Dave , Seems I need to have tested this code first. Regards Nick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/