Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbaGaObF (ORCPT ); Thu, 31 Jul 2014 10:31:05 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:56651 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbaGaObC (ORCPT ); Thu, 31 Jul 2014 10:31:02 -0400 Message-ID: <1406817052.17194.12.camel@marge.simpson.net> Subject: Re: [PATCH] locking/mutexes: Revert "locking/mutexes: Add extra reschedule point" From: Mike Galbraith To: Peter Zijlstra Cc: Ilya Dryomov , Linux Kernel Mailing List , Ingo Molnar , Ceph Development , davidlohr@hp.com, jason.low2@hp.com Date: Thu, 31 Jul 2014 16:30:52 +0200 In-Reply-To: <20140731131331.GT19379@twins.programming.kicks-ass.net> References: <1406801797-20139-1-git-send-email-ilya.dryomov@inktank.com> <20140731115759.GS19379@twins.programming.kicks-ass.net> <20140731131331.GT19379@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2014-07-31 at 15:13 +0200, Peter Zijlstra wrote: > Smells like maybe current->state != TASK_RUNNING Bingo [ 1200.851004] kjournald D 0000000000000002 0 4398 2 0x00000000 [ 1200.858283] ffff8803537bb788 0000000000000046 ffff8803537bb7a8 0000000000000000 [ 1200.865914] ffff880423324b60 0000000000012f80 ffff8803537bbfd8 0000000000012f80 [ 1200.873590] ffff88042937cb60 ffff880423324b60 ffff880428ceb240 ffff8804231e59b8 [ 1200.881256] Call Trace: [ 1200.883724] [] schedule+0x29/0x70 [ 1200.888798] [] schedule_preempt_disabled+0xe/0x10 [ 1200.895239] [] __mutex_lock_slowpath+0x1b5/0x1c0 [ 1200.901673] [] ? ceph_str_hash+0x26/0x80 [libceph] [ 1200.908198] [] mutex_lock+0x23/0x37 [ 1200.913430] [] ceph_con_send+0x4d/0x130 [libceph] [ 1200.919912] [] __send_queued+0x120/0x150 [libceph] [ 1200.926444] [] __ceph_osdc_start_request+0x5b/0xd0 [libceph] [ 1200.933855] [] ceph_osdc_start_request+0x51/0x80 [libceph] [ 1200.941126] [] rbd_obj_request_submit.isra.25+0x10/0x20 [rbd] [ 1200.948622] [] rbd_img_obj_request_submit+0x1ce/0x460 [rbd] [ 1200.956040] [] rbd_img_request_submit+0x4c/0x60 [rbd] [ 1200.962845] [] rbd_request_fn+0x238/0x290 [rbd] [ 1200.969108] [] __blk_run_queue+0x37/0x50 [ 1200.974764] [] queue_unplugged+0x3d/0xc0 [ 1200.980424] [] blk_flush_plug_list+0x1db/0x210 [ 1200.986635] [] io_schedule+0x78/0xd0 [ 1200.991954] [] get_request+0x414/0x800 [ 1200.997440] [] ? bio_attempt_back_merge+0x37/0x100 [ 1201.004013] [] ? __wake_up_sync+0x20/0x20 [ 1201.009782] [] blk_queue_bio+0xcc/0x360 [ 1201.015353] [] generic_make_request+0xc0/0x100 [ 1201.021605] [] submit_bio+0x75/0x140 [ 1201.026921] [] _submit_bh+0x136/0x1f0 [ 1201.032390] [] journal_do_submit_data+0x41/0x50 [ 1201.038662] [] journal_commit_transaction+0x1150/0x1350 [ 1201.045683] [] ? try_to_del_timer_sync+0x4f/0x70 [ 1201.052043] [] kjournald+0xe1/0x260 [ 1201.057324] [] ? __wake_up_sync+0x20/0x20 [ 1201.063072] [] ? commit_timeout+0x10/0x10 [ 1201.068855] [] kthread+0xc9/0xe0 [ 1201.073819] [] ? flush_kthread_worker+0xb0/0xb0 [ 1201.080084] [] ret_from_fork+0x7c/0xb0 [ 1201.085573] [] ? flush_kthread_worker+0xb0/0xb0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/