Date: Thu, 31 Jul 2014 18:35:24 +0200
From: Robert Richter <rric@kernel.org>
To: Rob Herring <robherring2@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        Will Deacon <Will.Deacon@arm.com>, Rob Herring <robh+dt@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, Pawel Moll <Pawel.Moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Radha Mohan Chintakuntla <rchintakuntla@cavium.com>,
        Robert Richter <rrichter@cavium.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/5] arm64, thunder: Add initial dts for Cavium Thunder
 SoC
Message-ID: <20140731163524.GT4703@rric.localhost>
References: <1406732794-20920-1-git-send-email-rric@kernel.org>
 <1406732794-20920-3-git-send-email-rric@kernel.org>
 <20140730154626.GD20162@leverpostej>
 <CAL_JsqLJ_W34XTF2aMOW9z+Gq4oxbrX1RztyJN8Mi0OFPeNxfg@mail.gmail.com>
 <20140731123443.GS4703@rric.localhost>
 <CAL_JsqKgfjV4sEZOWuH4YcMjeOA_yNDvZLv_jTi_Sb=27cOD3g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL_JsqKgfjV4sEZOWuH4YcMjeOA_yNDvZLv_jTi_Sb=27cOD3g@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On 31.07.14 10:22:19, Rob Herring wrote:
> On Thu, Jul 31, 2014 at 7:34 AM, Robert Richter <rric@kernel.org> wrote:
> > On 30.07.14 11:37:38, Rob Herring wrote:
> >> On Wed, Jul 30, 2014 at 10:46 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> >> > On Wed, Jul 30, 2014 at 04:06:31PM +0100, Robert Richter wrote:
> >> >> From: Radha Mohan Chintakuntla <rchintakuntla@cavium.com>
> >
> >> >> +/ {
> >> >> +     model = "Cavium ThunderX CN88XX Family";
> >> >> +     compatible = "cavium,thunder-88xx";
> >> >
> >> > Please don't use wildcards in compatible strings. Give this an absolute
> >> > name, and override as necessary.
> >
> > The naming 88xx refers to the processor family and arn't actually
> > wildcards. In the future we might need another dts file for 87xx, but
> > so far all SoCs of 88xx family should use the same dts files. In this
> > sense the naming is very specific.
> 
> Yes, but each implementation can have its own errata. You might not
> need to distinguish them now, but you could in the future.
> 
> However, if the family is really all the same die and different parts
> are just marketing, then the name is fine. Or if you can easily probe
> the exact part and revision it's probably fine.

Yes, this relates to the same soc.

> 
> >
> >
> >> >> +     cpus {
> >> >> +             #address-cells = <2>;
> >> >> +             #size-cells = <0>;
> >> >> +
> >> >> +             cpu@000 {
> >> >> +                     device_type = "cpu";
> >> >> +                     compatible = "cavium,thunder", "arm,armv8";
> >> >> +                     reg = <0x0 0x000>;
> >> >> +                     enable-method = "psci";
> >> >> +             };
> >> >
> >> > Just to check: both the SoC and CPU are called thunder?
> >
> > The soc is called thunder-88xx, the cpu thunder. E.g. an 87xx soc will
> > have the same core in which is thunder.
> 
> And the next version of the core would be called something else?
> thunder-v2? lightning? As long as they are distinguishable they should
> be fine.

Same here, the name relates to the same core.

-Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/