Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753539AbaGaXvR (ORCPT ); Thu, 31 Jul 2014 19:51:17 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:58557 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbaGaXvP convert rfc822-to-8bit (ORCPT ); Thu, 31 Jul 2014 19:51:15 -0400 MIME-Version: 1.0 X-Originating-IP: [95.21.61.92] In-Reply-To: <1406755767-5910-1-git-send-email-afaerber@suse.de> References: <1406755767-5910-1-git-send-email-afaerber@suse.de> Date: Fri, 1 Aug 2014 01:51:13 +0200 Message-ID: Subject: Re: [PATCH v3] Documentation: devicetree: Fix tps65090 typos in example From: Javier Martinez Canillas To: =?UTF-8?Q?Andreas_F=C3=A4rber?= Cc: Mark Brown , Lee Jones , Liam Girdwood , Samuel Ortiz , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , open list Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andreas, On Wed, Jul 30, 2014 at 11:29 PM, Andreas Färber wrote: > Specification and existing device trees use vsys-l{1,2}-supply, > not vsys_l{1,2}-supply. Fix the example to match the specification. > > Reviewed-by: Doug Anderson > Acked-by: Mark Rutland > Fixes: 21d2202158e9 ("mfd: tps65090: add DT support for tps65090") > Signed-off-by: Andreas Färber > --- > v2 -> v3: > * Added Fixes header > * + regulator and mfd maintainers > > v1 -> v2: > * More verbose commit message (requested by Mark Rutland) > > Documentation/devicetree/bindings/regulator/tps65090.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/tps65090.txt b/Documentation/devicetree/bindings/regulator/tps65090.txt > index 340980239ea9..ca69f5e3040c 100644 > --- a/Documentation/devicetree/bindings/regulator/tps65090.txt > +++ b/Documentation/devicetree/bindings/regulator/tps65090.txt > @@ -45,8 +45,8 @@ Example: > infet5-supply = <&some_reg>; > infet6-supply = <&some_reg>; > infet7-supply = <&some_reg>; > - vsys_l1-supply = <&some_reg>; > - vsys_l2-supply = <&some_reg>; > + vsys-l1-supply = <&some_reg>; > + vsys-l2-supply = <&some_reg>; > True, these also matches the .supply_name used when registering the LDO[1-2] regulators in the tps65090 driver. So clearly the example was wrong while the property specification is correct. Reviewed-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/