Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751432AbaJAIZp (ORCPT ); Wed, 1 Oct 2014 04:25:45 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:49027 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbaJAIZm (ORCPT ); Wed, 1 Oct 2014 04:25:42 -0400 Message-ID: <542BBA81.2000406@monstr.eu> Date: Wed, 01 Oct 2014 10:25:37 +0200 From: Michal Simek Reply-To: monstr@monstr.eu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Michal Simek , linux-kernel@vger.kernel.org CC: Subbaraya Sundeep Bhatta , Anirudha Sarangi , John Linn , "David S. Miller" , =?windows-1252?Q?Manuel_Sch=F6lling?= , Paul Gortmaker , Julia Lawall , Joe Perches , Ricardo Ribalda , Eric Dumazet , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: xilinx: Remove unnecessary ether_setup after alloc_etherdev References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2d9c4B3TCV7M7xxxsgIWtuEnsPUi7sq3T" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2d9c4B3TCV7M7xxxsgIWtuEnsPUi7sq3T Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 10/01/2014 08:00 AM, Michal Simek wrote: > From: Subbaraya Sundeep Bhatta >=20 > Calling ether_setup is redundant since alloc_etherdev calls it. >=20 > Signed-off-by: Subbaraya Sundeep Bhatta > Signed-off-by: Michal Simek > --- >=20 > drivers/net/ethernet/xilinx/ll_temac_main.c | 1 - > drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - > 2 files changed, 2 deletions(-) >=20 > diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/= ethernet/xilinx/ll_temac_main.c > index fda5891835d4..629077050fce 100644 > --- a/drivers/net/ethernet/xilinx/ll_temac_main.c > +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c > @@ -1012,7 +1012,6 @@ static int temac_of_probe(struct platform_device = *op) > if (!ndev) > return -ENOMEM; >=20 > - ether_setup(ndev); > platform_set_drvdata(op, ndev); > SET_NETDEV_DEV(ndev, &op->dev); > ndev->flags &=3D ~IFF_MULTICAST; /* clear multicast */ > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/driver= s/net/ethernet/xilinx/xilinx_axienet_main.c > index c8fd94133ecd..4ea2d4e6f1d1 100644 > --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c > @@ -1485,7 +1485,6 @@ static int axienet_of_probe(struct platform_devic= e *op) > if (!ndev) > return -ENOMEM; >=20 > - ether_setup(ndev); > platform_set_drvdata(op, ndev); >=20 > SET_NETDEV_DEV(ndev, &op->dev); > -- > 1.8.2.3 >=20 Please ignore this one it is already applied for axienet. Will send v2 just for ll_temac. Thanks, Michal --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform --2d9c4B3TCV7M7xxxsgIWtuEnsPUi7sq3T Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAlQruoEACgkQykllyylKDCEBhgCeKHPc4szkECMN7UaTpzIfaagJ bBoAoIIJo7dEEsMYXwWY+rPFWah4YB9X =N+Nd -----END PGP SIGNATURE----- --2d9c4B3TCV7M7xxxsgIWtuEnsPUi7sq3T-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/