Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501AbaJBGuy (ORCPT ); Thu, 2 Oct 2014 02:50:54 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:40093 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbaJBGuv convert rfc822-to-8bit (ORCPT ); Thu, 2 Oct 2014 02:50:51 -0400 Date: Thu, 2 Oct 2014 09:50:46 +0300 From: Mihai =?UTF-8?B?RG9uyJt1?= To: Yann Droneaud Cc: Andrew Morton , Heinrich Schuchardt , Eric Paris , Richard Guy Briggs , Al Viro , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org, linux-api@vger.kernel.org, Jan Kara , Lino Sanfilippo , Valdis Kletnieks , Michael Kerrisk-manpages Subject: Re: [PATCHv8.1] fanotify: enable close-on-exec on events' fd when requested in fanotify_init() Message-ID: <20141002095046.3715eb69@mdontu-l> In-Reply-To: <1412230855.28184.5.camel@localhost.localdomain> References: <9d050a2db4f9cf68cd6cb038f16cccb0f73c6e66.1411562410.git.ydroneaud@opteya.com> <542481B3.8070300@gmx.de> <1411721898.7778.18.camel@localhost.localdomain> <542666B2.9080700@gmx.de> <1411980555-10818-1-git-send-email-ydroneaud@opteya.com> <20141001153621.65e9258e65a6167bf2e4cb50@linux-foundation.org> <1412230855.28184.5.camel@localhost.localdomain> Organization: Home MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 02 Oct 2014 08:20:55 +0200 Yann Droneaud wrote: > Hi, > > Le mercredi 01 octobre 2014 à 15:36 -0700, Andrew Morton a écrit : > > On Mon, 29 Sep 2014 10:49:15 +0200 Yann Droneaud wrote: > > > > > According to commit 80af258867648 ('fanotify: groups can specify > > > their f_flags for new fd'), file descriptors created as part of > > > file access notification events inherit flags from the > > > event_f_flags argument passed to syscall fanotify_init(2). > > > > > > So while it is legal for userspace to call fanotify_init() with > > > O_CLOEXEC as part of its second argument, O_CLOEXEC is currently > > > silently ignored. > > > > > > Indeed event_f_flags are only given to dentry_open(), which only > > > seems to care about O_ACCMODE and O_PATH in do_dentry_open(), > > > O_DIRECT in open_check_o_direct() and O_LARGEFILE in > > > generic_file_open(). > > > > > > But it seems logical to set close-on-exec flag on the file > > > descriptor if userspace is allowed to request it with O_CLOEXEC. > > > > > > In fact, according to some lookup on http://codesearch.debian.net/ > > > and various search engine, there's already some userspace code > > > requesting it: > > > > > > - in systemd's readahead[2]: > > > > > > fanotify_fd = fanotify_init(FAN_CLOEXEC|FAN_NONBLOCK, O_RDONLY|O_LARGEFILE|O_CLOEXEC|O_NOATIME); > > > > > > - in clsync[3]: > > > > > > #define FANOTIFY_EVFLAGS (O_LARGEFILE|O_RDONLY|O_CLOEXEC) > > > > > > int fanotify_d = fanotify_init(FANOTIFY_FLAGS, FANOTIFY_EVFLAGS); > > > > > > - in examples [4] from "Filesystem monitoring in the Linux > > > kernel" article[5] by Aleksander Morgado: > > > > > > if ((fanotify_fd = fanotify_init (FAN_CLOEXEC, > > > O_RDONLY | O_CLOEXEC | O_LARGEFILE)) < 0) > > > > So we have a number of apps which are setting O_CLOEXEC, but it doesn't > > actually work. With this change it *will* work, so the behaviour of > > those apps might change, possibly breaking them? > > > > In the other hand, not enabling close-on-exec might expose unwanted file > descriptor to childs, creating security issues. YMMV. > As someone who uses fanotify for content introspection, I can say that I am _explicitly_ marking the fd obtained via read() as O_CLOEXEC, because I have encountered a situation where a child managed to create a deadlock because it kept the fd open after the main application responded with FAN_ALLOW. -- Mihai Donțu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/