Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751391AbaJBJ1P (ORCPT ); Thu, 2 Oct 2014 05:27:15 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:46181 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbaJBJ1O (ORCPT ); Thu, 2 Oct 2014 05:27:14 -0400 Date: Thu, 2 Oct 2014 10:27:21 +0100 From: Will Deacon To: Min-Hua Chen Cc: Catalin Marinas , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Use phys_addr_t type for physical address (arm64) Message-ID: <20141002092721.GB24016@arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 01, 2014 at 03:26:55PM +0100, Min-Hua Chen wrote: > I found that valid_phys_addr_range does not use > phys_addr_t to describe physical address. > Is it better to change the type from unsigned long to phys_addr_t? Yes, that looks like a sensible change. Both types are 64-bit on arm64, so it shouldn't affect functionality. Can you resend as a proper patch (with commit message) please? Will > Signed-off-by: Min-Hua Chen > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > index e0ecdcf..f771e8b 100644 > --- a/arch/arm64/include/asm/io.h > +++ b/arch/arm64/include/asm/io.h > @@ -243,7 +243,7 @@ extern void __iomem *ioremap_cache(phys_addr_t > phys_addr, size_t size); > * (PHYS_OFFSET and PHYS_MASK taken into account). > */ > #define ARCH_HAS_VALID_PHYS_ADDR_RANGE > -extern int valid_phys_addr_range(unsigned long addr, size_t size); > +extern int valid_phys_addr_range(phys_addr_t addr, size_t size); > extern int valid_mmap_phys_addr_range(unsigned long pfn, size_t size); > > extern int devmem_is_allowed(unsigned long pfn); > diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c > index 8ed6cb1..1d73662 100644 > --- a/arch/arm64/mm/mmap.c > +++ b/arch/arm64/mm/mmap.c > @@ -102,7 +102,7 @@ EXPORT_SYMBOL_GPL(arch_pick_mmap_layout); > * You really shouldn't be using read() or write() on /dev/mem. This might go > * away in the future. > */ > -int valid_phys_addr_range(unsigned long addr, size_t size) > +int valid_phys_addr_range(phys_addr_t addr, size_t size) > { > if (addr < PHYS_OFFSET) > return 0; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/