Message-id: <542D4F4B.90400@samsung.com>
Date: Thu, 02 Oct 2014 16:12:43 +0300
From: Dmitry Kasatkin <d.kasatkin@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.1.2
MIME-version: 1.0
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Roberto Sassu <roberto.sassu@polito.it>
Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
        linux-ima-devel@lists.sourceforge.net,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Linux-ima-devel] [PATCH v2 3/4] ima: check appraisal flag in the
 ima_file_free() hook
References: <cover.1412188590.git.d.kasatkin@samsung.com>
 <600aeb6a5b8eca7eb381392e142ca71484717e9c.1412188590.git.d.kasatkin@samsung.com>
 <542D0C33.2010700@polito.it> <542D1B4B.7040904@samsung.com>
 <542D2398.8000300@polito.it> <542D2C56.9040505@samsung.com>
 <542D3A28.5000603@polito.it>
 <1412255026.15991.32.camel@dhcp-9-2-203-236.watson.ibm.com>
In-reply-to: <1412255026.15991.32.camel@dhcp-9-2-203-236.watson.ibm.com>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 02/10/14 16:03, Mimi Zohar wrote:
>> Ok, thanks.
>> > 
>> > Acked-by: Roberto Sassu <roberto.sassu@polito.it>
>> > 
>> > Roberto Sassu
> Thanks, Dmitry, Roberto.  The patch and update description looks good.
> Please post the updated patch inline here on the mailing list.
>
> thanks,
>
> Mimi
>
>

Mimi, patch is the same what I posted 9:21 GMT and what Roberto acked.
Patch description updated based on Roberto's and Your comments

    ima: check ima_policy_flag in the ima_file_free() hook
   
    This patch completes the switching to the 'ima_policy_flag' variable
    in the checks at the beginning of IMA functions, starting with the
    commit a756024e.
   
    Checking 'iint_initialized' is completely unnecessary, because
    S_IMA flag is unset if iint was not allocated. At the same time
    the integrity cache is allocated with SLAB_PANIC and the kernel will
    panic if the allocation fails during kernel initialization. So on
    a running system iint_initialized is always true and can be removed.
   
    Changes in v3:
    * not limiting test to IMA_APPRAISE (spotted by Roberto Sassu)
   
    Changes in v2:
    * 'iint_initialized' removal patch merged to this patch (requested
       by Mimi)
   
    Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com>
    Acked-by: Roberto Sassu <roberto.sassu@polito.it>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/