Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754436AbaJBQFw (ORCPT ); Thu, 2 Oct 2014 12:05:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64941 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbaJBQFv (ORCPT ); Thu, 2 Oct 2014 12:05:51 -0400 Date: Thu, 2 Oct 2014 17:08:27 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , linux-kernel@vger.kernel.org, Adrian Hunter , Corey Ashford , David Ahern , Frederic Weisbecker , Ingo Molnar , Milian Wolff , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH 2/5] perf tools: Move callchain_param to util object in to fix python test Message-ID: <20141002150827.GK9764@krava.brq.redhat.com> References: <1412179229-19466-1-git-send-email-jolsa@kernel.org> <1412179229-19466-2-git-send-email-jolsa@kernel.org> <20141002145949.GK2799@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141002145949.GK2799@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 02, 2014 at 11:59:49AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 01, 2014 at 06:00:26PM +0200, Jiri Olsa escreveu: > > In following commit we changed the location of callchains data: > > b016b5ba554b perf tools: Move callchain config from record_opts to callchain_param > > > > Now all callchains stuff stays in callchain_param struct, > > which adds its dependency for evsel.c object and breaks > > python perf.so usage (unresolved callchain_param). > > > > Moving callchain_param into callchain.c and adding it into > > python-ext-sources unleash just another dependency hell, > > so I ended up adding callchain_param into util.c for now. > > Against what branch is the patch? I am not finding b016b5ba554b in none [jolsa@krava perf]$ git describe --contains b016b5ba554b fatal: cannot describe 'b016b5ba554ba38c74241ef8739f8fde8878d3eb' [jolsa@krava perf]$ git show --oneline b016b5ba554b | head -1 b016b5ba554b perf tools: Move callchain config from record_opts to callchain_param [jolsa@krava perf]$ git show 72a128aa083a > /tmp/p [jolsa@krava perf]$ git show b016b5ba554b > /tmp/p1 [jolsa@krava perf]$ diff -puw /tmp/p /tmp/p1 --- /tmp/p 2014-10-02 17:06:20.072958720 +0200 +++ /tmp/p1 2014-10-02 17:06:26.035946113 +0200 @@ -1,4 +1,4 @@ -commit 72a128aa083a7f4cc4f800718aaae05d9c698e26 +commit b016b5ba554ba38c74241ef8739f8fde8878d3eb Author: Namhyung Kim Date: Tue Sep 23 10:01:41 2014 +0900 I guess I took some version before your rebase > of the branches in my linux git repo and the python 'perf test' entry > works as expected: > > [root@zoo ~]# perf test python > 17: Try 'use perf' in python, checking link problems : Ok > [root@zoo ~]# hum.. yours acme/perf/core is failing for me: [jolsa@krava perf]$ ./perf test python 17: Try 'use perf' in python, checking link problems : FAILED! [jolsa@krava perf]$ git show --oneline HEAD | head -1 281f92f233a5 perf record: Fix error message for --filter option not coming after tracepoint maybe you need 'make clean && make' ? jirka > > - Arnaldo > > > Cc: Adrian Hunter > > Cc: Arnaldo Carvalho de Melo > > Cc: Corey Ashford > > Cc: David Ahern > > Cc: Frederic Weisbecker > > Cc: Ingo Molnar > > Cc: Milian Wolff > > Cc: Namhyung Kim > > Cc: Paul Mackerras > > Cc: Peter Zijlstra > > Signed-off-by: Jiri Olsa > > --- > > tools/perf/util/hist.c | 7 ------- > > tools/perf/util/util.c | 8 ++++++++ > > 2 files changed, 8 insertions(+), 7 deletions(-) > > > > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c > > index 86569fa3651d..b47595697140 100644 > > --- a/tools/perf/util/hist.c > > +++ b/tools/perf/util/hist.c > > @@ -14,13 +14,6 @@ static bool hists__filter_entry_by_thread(struct hists *hists, > > static bool hists__filter_entry_by_symbol(struct hists *hists, > > struct hist_entry *he); > > > > -struct callchain_param callchain_param = { > > - .mode = CHAIN_GRAPH_REL, > > - .min_percent = 0.5, > > - .order = ORDER_CALLEE, > > - .key = CCKEY_FUNCTION > > -}; > > - > > u16 hists__col_len(struct hists *hists, enum hist_column col) > > { > > return hists->col_len[col]; > > diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c > > index 24e8d871b74e..d5eab3f3323f 100644 > > --- a/tools/perf/util/util.c > > +++ b/tools/perf/util/util.c > > @@ -14,6 +14,14 @@ > > #include > > #include > > #include > > +#include "callchain.h" > > + > > +struct callchain_param callchain_param = { > > + .mode = CHAIN_GRAPH_REL, > > + .min_percent = 0.5, > > + .order = ORDER_CALLEE, > > + .key = CCKEY_FUNCTION > > +}; > > > > /* > > * XXX We need to find a better place for these things... > > -- > > 1.9.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/