Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbaJBQkV (ORCPT ); Thu, 2 Oct 2014 12:40:21 -0400 Received: from mail-ob0-f171.google.com ([209.85.214.171]:58796 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752141AbaJBQkR (ORCPT ); Thu, 2 Oct 2014 12:40:17 -0400 MIME-Version: 1.0 In-Reply-To: <20141002083635.GF9764@krava.brq.redhat.com> References: <20141002083635.GF9764@krava.brq.redhat.com> Date: Thu, 2 Oct 2014 18:40:14 +0200 Message-ID: Subject: Re: [BUG] perf tools: off-by-one error in map_groups__find_ams() From: Stephane Eranian To: Jiri Olsa Cc: LKML , Namhyung Kim , Arnaldo Carvalho de Melo , Peter Zijlstra , "mingo@elte.hu" , David Ahern Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 2, 2014 at 10:36 AM, Jiri Olsa wrote: > On Wed, Oct 01, 2014 at 09:16:31PM +0200, Stephane Eranian wrote: >> Hi, >> >> It appears that there is a off-by-one bug in map_groups__find_ams(). >> The upper-bound check in the test below should be >= because >> end = start + len; The end address is outside the range. >> >> Please confirm. >> >> >> int map_groups__find_ams(struct addr_map_symbol *ams, symbol_filter_t filter) >> { >> if (ams->addr < ams->map->start || ams->addr > ams->map->end) { > > yep, looks like bug to me > Are you providing a fix or should I? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/