Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753978AbaJBRB5 (ORCPT ); Thu, 2 Oct 2014 13:01:57 -0400 Received: from p3plex2out04.prod.phx3.secureserver.net ([184.168.131.18]:48529 "EHLO p3plex2out04.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753443AbaJBRBy (ORCPT ); Thu, 2 Oct 2014 13:01:54 -0400 From: Hartley Sweeten To: Chen Gang , "abbotti@mev.co.uk" , "gregkh@linuxfoundation.org" , "luca.ellero@brickedbrain.com" , "lisovy@gmail.com" CC: "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Richard Weinberger" Subject: RE: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM Thread-Topic: [PATCH] drivers/staging/comedi/Kconfig: Let COMEDI_II_PCI20KC depend on HAS_IOMEM Thread-Index: AQHP3k4gow5hFBlhm02F4sKBzxlCjZwdB36A Date: Thu, 2 Oct 2014 17:01:53 +0000 Message-ID: References: <542D640E.6010200@gmail.com> In-Reply-To: <542D640E.6010200@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [184.183.19.121] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s92H22EL007419 On Thursday, October 02, 2014 7:41 AM, Chen Gang wrote: > COMEDI_II_PCI20KC needs HAS_IOMEM, so depend on it. The related error ( > with allmodconfig under um): > > CC [M] drivers/staging/comedi/drivers/ii_pci20kc.o > drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_attach’: > drivers/staging/comedi/drivers/ii_pci20kc.c:442:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration] > dev->mmio = ioremap(membase, II20K_SIZE); > ^ > drivers/staging/comedi/drivers/ii_pci20kc.c:442:12: warning: assignment makes pointer from integer without a cast [enabled by default] > dev->mmio = ioremap(membase, II20K_SIZE); > ^ > drivers/staging/comedi/drivers/ii_pci20kc.c: In function ‘ii20k_detach’: > drivers/staging/comedi/drivers/ii_pci20kc.c:512:3: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration] > iounmap(dev->mmio); > ^ > > Signed-off-by: Chen Gang > --- > drivers/staging/comedi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig > index a8bc2b5..b709736 100644 > --- a/drivers/staging/comedi/Kconfig > +++ b/drivers/staging/comedi/Kconfig > @@ -426,6 +426,7 @@ config COMEDI_AIO_IIRO_16 > > config COMEDI_II_PCI20KC > tristate "Intelligent Instruments PCI-20001C carrier support" > + depends on HAS_IOMEM > ---help--- > Enable support for Intelligent Instruments PCI-20001C carrier > PCI-20001, PCI-20006 and PCI-20341 This seems appropriate. Reviewed-by: H Hartley Sweeten ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?