Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753562AbaJBRDf (ORCPT ); Thu, 2 Oct 2014 13:03:35 -0400 Received: from resqmta-po-08v.sys.comcast.net ([96.114.154.167]:50210 "EHLO resqmta-po-08v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbaJBRDd (ORCPT ); Thu, 2 Oct 2014 13:03:33 -0400 Date: Thu, 2 Oct 2014 12:03:30 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Andrew Morton cc: "Kirill A. Shutemov" , Sasha Levin , Dave Hansen , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] mm: generalize VM_BUG_ON() macros In-Reply-To: <20141001130523.d7cf46e735089d681194e8e6@linux-foundation.org> Message-ID: References: <1412163121-4295-1-git-send-email-kirill.shutemov@linux.intel.com> <20141001130523.d7cf46e735089d681194e8e6@linux-foundation.org> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Oct 2014, Andrew Morton wrote: > I can't say I'm a fan of this. We don't do this sort of thing anywhere > else in the kernel and passing different types to the same thing in > different places is unusual and exceptional. We gain very little from > this so why bother? I feel the same. This smells awfully like C++ overloading of functions etc which I think often confuses the heck out of people. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/