Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752716AbaJCMWx (ORCPT ); Fri, 3 Oct 2014 08:22:53 -0400 Received: from mail-la0-f45.google.com ([209.85.215.45]:63168 "EHLO mail-la0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752421AbaJCMWt (ORCPT ); Fri, 3 Oct 2014 08:22:49 -0400 MIME-Version: 1.0 In-Reply-To: References: <1411367422-2095-1-git-send-email-ssreedharan@mvista.com> Date: Fri, 3 Oct 2014 14:22:47 +0200 X-Google-Sender-Auth: SmvfX9PtG9RZLEvLD362RJfEsIM Message-ID: Subject: Re: [PATCH] serial/core: Initialize the console pm state From: Geert Uytterhoeven To: Kevin Hilman Cc: Sudhir Sreedharan , linux-serial@vger.kernel.org, Greg KH , Jiri Slaby , lkml , Olof Johansson , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 1, 2014 at 7:27 PM, Kevin Hilman wrote: > On Sun, Sep 21, 2014 at 11:30 PM, Sudhir Sreedharan > wrote: >> For console devices having UART_CAP_SLEEP capability, the uart_pm_state has >> to be initialized to UART_PM_STATE_ON. Otherwise the LCR regiser values >> are reinitialized when uart_change_pm is called from uart_configure_port. >> >> Signed-off-by: Sudhir Sreedharan > > Multiple boot failures on ARM[1] were bisected down to this patch. > > How was this patch tested, and on which platforms? > > Also, the changelog states that this should be done only for > UART_CAP_SLEEP, but the patch does it for every UART. > > Greg, I suggest this patch be dropped from tty-next until it has been > better described and tested. > > Kevin > > [1] http://lists.linaro.org/pipermail/kernel-build-reports/2014-October/005550.html Perhaps it should call "uart_change_pm(state, UART_PM_STATE_ON)" instead, so the driver's .pm() method is called? UART_CAP_SLEEP seems to be an 8250-only flag. BTW, this was the first commit I reverted when I had an issue with a serial console yesterday, but it didn't seem to have any influence (for me). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/