Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbaJCMdC (ORCPT ); Fri, 3 Oct 2014 08:33:02 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:64818 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbaJCMdA (ORCPT ); Fri, 3 Oct 2014 08:33:00 -0400 From: Matt Fleming To: Alessandro Zummo , rtc-linux@googlegroups.com, Mark Salter Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Fleming , Dave Young Subject: [PATCH] rtc: Disable EFI rtc for x86 Date: Fri, 3 Oct 2014 13:32:56 +0100 Message-Id: <1412339576-17972-1-git-send-email-matt@console-pimps.org> X-Mailer: git-send-email 1.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matt Fleming commit da167ad7638759 ("rtc: ia64: allow other architectures to use EFI RTC") inadvertently introduced a regression for x86. We've been careful not to enable the EFI rtc driver for x86 due to the generally buggy implementations of the time-related EFI runtime services. Previous attempts have been made to us the time EFI services, but all have eventually been reverted due to crashes inside the firmware code. In fact, since the above commit was merged we've seen reports of crashes on 32-bit tablets, https://bugzilla.kernel.org/show_bug.cgi?id=84241#c21 Disable it explicitly for x86 so that we don't give users false hope that this driver will work - it won't, and your machine is likely to crash. Cc: Mark Salter Cc: Dave Young Cc: Alessandro Zummo Signed-off-by: Matt Fleming --- Unless anyone objects, I'm happy to take this through the EFI tree. drivers/rtc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index a168e96142b9..54ef393b0def 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -806,7 +806,7 @@ config RTC_DRV_DA9063 config RTC_DRV_EFI tristate "EFI RTC" - depends on EFI + depends on EFI && !X86 help If you say yes here you will get support for the EFI Real Time Clock. -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/