Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754748AbaJCUBe (ORCPT ); Fri, 3 Oct 2014 16:01:34 -0400 Received: from homie.mail.dreamhost.com ([208.97.132.208]:52571 "EHLO homiemail-a99.g.dreamhost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754426AbaJCUB3 (ORCPT ); Fri, 3 Oct 2014 16:01:29 -0400 Message-ID: <1412366467.20838.5.camel@linux-t7sj.site> Subject: Re: [PATCH v3 3/5] selftests/ipc: change test to use ksft framework From: Davidlohr Bueso To: Shuah Khan Cc: akpm@linux-foundation.org, gregkh@linuxfoundation.org, colin.king@canonical.com, luto@amacapital.net, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 03 Oct 2014 13:01:07 -0700 In-Reply-To: <542EFC36.1010306@osg.samsung.com> References: <1412357993.20838.4.camel@linux-t7sj.site> <542EFC36.1010306@osg.samsung.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-10-03 at 13:42 -0600, Shuah Khan wrote: > On 10/03/2014 11:39 AM, Davidlohr Bueso wrote: > > On Fri, 2014-10-03 at 09:36 -0600, Shuah Khan wrote: > >> msgque.key = ftok(argv[0], 822155650); > >> if (msgque.key == -1) { > >> - printf("Can't make key\n"); > >> - return -errno; > >> + printf("Can't make key: %d\n", -errno); > > > > So printing a numeric value is quite useless when users actually run > > into these errors -- which is why I like err() so much. How about using > > strerror() instead? > > > > Yes. using perror() does give better information. There are other > places in this file that use errno. How about I make that a separate > patch and catch all of them at once to use perror() as a follow-up > change? That way I fix all at once without adding more changes to > this patch. Sounds good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/